RE: [PATCH 5/7] v4l: videobuf2: add read() emulator

2010-10-25 Thread Marek Szyprowski
Hello, On Monday, October 25, 2010 2:13 AM Pawel Osciak wrote: Hi Marek, This is a pretty crafty patch, you've managed to make it nice and clean, without adding complexity to streaming code. Nice job. A few of my comments below. Thanks! On Tue, Oct 19, 2010 at 23:41, Marek Szyprowski

Re: [PATCH 5/7] v4l: videobuf2: add read() emulator

2010-10-24 Thread Pawel Osciak
Hi Marek, This is a pretty crafty patch, you've managed to make it nice and clean, without adding complexity to streaming code. Nice job. A few of my comments below. On Tue, Oct 19, 2010 at 23:41, Marek Szyprowski m.szyprow...@samsung.com wrote: Add a generic read() emulator for videobuf2. It

[PATCH 5/7] v4l: videobuf2: add read() emulator

2010-10-20 Thread Marek Szyprowski
Add a generic read() emulator for videobuf2. It uses MMAP memory type buffers and generic vb2 calls: req_bufs, qbuf and dqbuf. Video date is being copied from mmap buffers to userspace with standard copy_to_user() function. To add read() support to the driver, only one additional structure should