Re: [PATCH 5/8] drivers/media/video/uvc: Use %pUl to print UUIDs

2009-11-04 Thread Laurent Pinchart 
Hi Joe,

On Saturday 31 October 2009 20:27:38 Joe Perches wrote:
 On Sat, 2009-10-31 at 20:10 +0100, Laurent Pinchart wrote:
  On Saturday 31 October 2009 10:07:01 Mauro Carvalho Chehab wrote:
   I'm assuming that those printk patches from Joe to uvc will go via your
tree, so please submit a pull request when they'll be ready for
   upstream.
 
  I'll submit the pull request as soon as the printk core patch hits
  upstream.
 
 I believe Andrew Morton has picked up the patches for
 his mm-commits set.  If you do nothing, these should
 show up in Linus' tree after awhile.

Thanks for the notice.

Andrew, could you please drop drivers-media-video-uvc-use-%pul-to-print-
uuids.patch ? I will push it through the v4l-dvb tree as I need to add 
backward compatibility support.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/8] drivers/media/video/uvc: Use %pUl to print UUIDs

2009-11-04 Thread Joe Perches 
On Wed, 2009-11-04 at 15:42 +0100, Laurent Pinchart wrote:
 Andrew, could you please drop drivers-media-video-uvc-use-%pul-to-print-
 uuids.patch ? I will push it through the v4l-dvb tree as I need to add 
 backward compatibility support.

One thing you might evaluate is how useful it is to continue
to support backward compatibility.

I think drivers/media is the only drivers directory except
staging to continue to use KERNEL_VERSION checks.

cheers, Joe

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/8] drivers/media/video/uvc: Use %pUl to print UUIDs

2009-10-31 Thread Mauro Carvalho Chehab 
Hi Laurent,

Em Mon, 12 Oct 2009 00:34:58 +0200
Laurent Pinchart laurent.pinch...@ideasonboard.com escreveu:

 As this will go through the linuxtv v4l-dvb tree, I'll have to add backward
 compatibility code (that will not make it to mainline). If that's ok with you
 it will be easier for me to test and apply that part of the patch through my
 tree once the vsprintf extension gets in. 

I'm assuming that those printk patches from Joe to uvc will go via your tree,
so please submit a pull request when they'll be ready for upstream.




Cheers,
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/8] drivers/media/video/uvc: Use %pUl to print UUIDs

2009-10-31 Thread Joe Perches 
On Sat, 2009-10-31 at 20:10 +0100, Laurent Pinchart wrote:
 On Saturday 31 October 2009 10:07:01 Mauro Carvalho Chehab wrote:
  I'm assuming that those printk patches from Joe to uvc will go via your
   tree, so please submit a pull request when they'll be ready for upstream.
 I'll submit the pull request as soon as the printk core patch hits upstream.

I believe Andrew Morton has picked up the patches for
his mm-commits set.  If you do nothing, these should
show up in Linus' tree after awhile.

lib-vsprintfc-add-%pu-to-print-uuid-guids.patch
fs-xfs-xfs_log_recoverc-use-%pu-to-print-uuids.patch
randomc-use-%pu-to-print-uuids.patch
drivers-firmware-dmi_scanc-use-%pub-to-print-uuids.patch
drivers-md-mdc-use-%pu-to-print-uuids.patch
fs-gfs2-sysc-use-%pub-to-print-uuids.patch
fs-ubifs-use-%pub-to-print-uuids.patch
efih-use-%pul-to-print-uuids.patch
drivers-media-video-uvc-use-%pul-to-print-uuids.patch
lib-unified-uuid-guid-definition.patch
gfs2-use-unified-uuid-guid-code.patch


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/8] drivers/media/video/uvc: Use %pUl to print UUIDs

2009-10-11 Thread Laurent Pinchart 
Hi Joe,

On Wednesday 07 October 2009 06:45:38 Joe Perches wrote:
 Signed-off-by: Joe Perches j...@perches.com
 ---
  drivers/media/video/uvc/uvc_ctrl.c   |   69 
 --
  drivers/media/video/uvc/uvc_driver.c |7 +--
  drivers/media/video/uvc/uvcvideo.h   |   10 -
  3 files changed, 35 insertions(+), 51 deletions(-)
 
 diff --git a/drivers/media/video/uvc/uvc_ctrl.c
  b/drivers/media/video/uvc/uvc_ctrl.c index c3225a5..4d06976 100644
 --- a/drivers/media/video/uvc/uvc_ctrl.c
 +++ b/drivers/media/video/uvc/uvc_ctrl.c
 @@ -1093,8 +1093,8 @@ int uvc_xu_ctrl_query(struct uvc_video_chain *chain,
 
   if (!found) {
   uvc_trace(UVC_TRACE_CONTROL,
 - Control  UVC_GUID_FORMAT /%u not found.\n,
 - UVC_GUID_ARGS(entity-extension.guidExtensionCode),
 + Control %pUl/%u not found.\n,
 + entity-extension.guidExtensionCode,
   xctrl-selector);
   return -EINVAL;
   }
 @@ -1171,9 +1171,9 @@ int uvc_ctrl_resume_device(struct uvc_device *dev)
   (ctrl-info-flags  UVC_CONTROL_RESTORE) == 0)
   continue;
 
 - printk(KERN_INFO restoring control  UVC_GUID_FORMAT
 - /%u/%u\n, UVC_GUID_ARGS(ctrl-info-entity),
 - ctrl-info-index, ctrl-info-selector);
 + printk(KERN_INFO restoring control %pUl/%u/%u\n,
 +ctrl-info-entity,
 +ctrl-info-index, ctrl-info-selector);
   ctrl-dirty = 1;
   }
 
 @@ -1228,46 +1228,43 @@ static void uvc_ctrl_add_ctrl(struct uvc_device
  *dev, dev-intfnum, info-selector, (__u8 *)size, 2);
   if (ret  0) {
   uvc_trace(UVC_TRACE_CONTROL, GET_LEN failed on 
 - control  UVC_GUID_FORMAT /%u (%d).\n,
 - UVC_GUID_ARGS(info-entity), info-selector,
 - ret);
 +   control %pUl/%u (%d).\n,
 +   info-entity, info-selector, ret);
   return;
   }
 
   if (info-size != le16_to_cpu(size)) {
 - uvc_trace(UVC_TRACE_CONTROL, Control  UVC_GUID_FORMAT
 - /%u size doesn't match user supplied 
 - value.\n, UVC_GUID_ARGS(info-entity),
 - info-selector);
 + uvc_trace(UVC_TRACE_CONTROL,
 +   Control %pUl/%u size doesn't match user 
 supplied value.\n,
 +   info-entity, info-selector);
   return;
   }
 
   ret = uvc_query_ctrl(dev, UVC_GET_INFO, ctrl-entity-id,
   dev-intfnum, info-selector, inf, 1);
   if (ret  0) {
 - uvc_trace(UVC_TRACE_CONTROL, GET_INFO failed on 
 - control  UVC_GUID_FORMAT /%u (%d).\n,
 - UVC_GUID_ARGS(info-entity), info-selector,
 - ret);
 + uvc_trace(UVC_TRACE_CONTROL,
 +   GET_INFO failed on control %pUl/%u (%d).\n,
 +   info-entity, info-selector, ret);
   return;
   }
 
   flags = info-flags;
   if (((flags  UVC_CONTROL_GET_CUR)  !(inf  (1  0))) ||
   ((flags  UVC_CONTROL_SET_CUR)  !(inf  (1  1 {
 - uvc_trace(UVC_TRACE_CONTROL, Control 
 - UVC_GUID_FORMAT /%u flags don't match 
 - supported operations.\n,
 - UVC_GUID_ARGS(info-entity), info-selector);
 + uvc_trace(UVC_TRACE_CONTROL,
 +   Control %pUl/%u flags don't match supported 
 operations.\n,
 +   info-entity, info-selector);
   return;
   }
   }
 
   ctrl-info = info;
   ctrl-data = kmalloc(ctrl-info-size * UVC_CTRL_NDATA, GFP_KERNEL);
 - uvc_trace(UVC_TRACE_CONTROL, Added control  UVC_GUID_FORMAT /%u 
 - to device %s entity %u\n, UVC_GUID_ARGS(ctrl-info-entity),
 - ctrl-info-selector, dev-udev-devpath, entity-id);
 + uvc_trace(UVC_TRACE_CONTROL,
 +   Added control %pUl/%u to device %s entity %u\n,
 +   ctrl-info-entity, ctrl-info-selector,
 +   dev-udev-devpath, entity-id);
  }
 
  /*
 @@ -1293,17 +1290,16 @@ int uvc_ctrl_add_info(struct uvc_control_info
  *info) continue;
 
   if (ctrl-selector == info-selector) {
 - uvc_trace(UVC_TRACE_CONTROL, Control 
 - UVC_GUID_FORMAT /%u is already

[PATCH 5/8] drivers/media/video/uvc: Use %pUl to print UUIDs

2009-10-06 Thread Joe Perches 
Signed-off-by: Joe Perches j...@perches.com
---
 drivers/media/video/uvc/uvc_ctrl.c   |   69 --
 drivers/media/video/uvc/uvc_driver.c |7 +--
 drivers/media/video/uvc/uvcvideo.h   |   10 -
 3 files changed, 35 insertions(+), 51 deletions(-)

diff --git a/drivers/media/video/uvc/uvc_ctrl.c 
b/drivers/media/video/uvc/uvc_ctrl.c
index c3225a5..4d06976 100644
--- a/drivers/media/video/uvc/uvc_ctrl.c
+++ b/drivers/media/video/uvc/uvc_ctrl.c
@@ -1093,8 +1093,8 @@ int uvc_xu_ctrl_query(struct uvc_video_chain *chain,
 
if (!found) {
uvc_trace(UVC_TRACE_CONTROL,
-   Control  UVC_GUID_FORMAT /%u not found.\n,
-   UVC_GUID_ARGS(entity-extension.guidExtensionCode),
+   Control %pUl/%u not found.\n,
+   entity-extension.guidExtensionCode,
xctrl-selector);
return -EINVAL;
}
@@ -1171,9 +1171,9 @@ int uvc_ctrl_resume_device(struct uvc_device *dev)
(ctrl-info-flags  UVC_CONTROL_RESTORE) == 0)
continue;
 
-   printk(KERN_INFO restoring control  UVC_GUID_FORMAT
-   /%u/%u\n, UVC_GUID_ARGS(ctrl-info-entity),
-   ctrl-info-index, ctrl-info-selector);
+   printk(KERN_INFO restoring control %pUl/%u/%u\n,
+  ctrl-info-entity,
+  ctrl-info-index, ctrl-info-selector);
ctrl-dirty = 1;
}
 
@@ -1228,46 +1228,43 @@ static void uvc_ctrl_add_ctrl(struct uvc_device *dev,
dev-intfnum, info-selector, (__u8 *)size, 2);
if (ret  0) {
uvc_trace(UVC_TRACE_CONTROL, GET_LEN failed on 
-   control  UVC_GUID_FORMAT /%u (%d).\n,
-   UVC_GUID_ARGS(info-entity), info-selector,
-   ret);
+ control %pUl/%u (%d).\n,
+ info-entity, info-selector, ret);
return;
}
 
if (info-size != le16_to_cpu(size)) {
-   uvc_trace(UVC_TRACE_CONTROL, Control  UVC_GUID_FORMAT
-   /%u size doesn't match user supplied 
-   value.\n, UVC_GUID_ARGS(info-entity),
-   info-selector);
+   uvc_trace(UVC_TRACE_CONTROL,
+ Control %pUl/%u size doesn't match user 
supplied value.\n,
+ info-entity, info-selector);
return;
}
 
ret = uvc_query_ctrl(dev, UVC_GET_INFO, ctrl-entity-id,
dev-intfnum, info-selector, inf, 1);
if (ret  0) {
-   uvc_trace(UVC_TRACE_CONTROL, GET_INFO failed on 
-   control  UVC_GUID_FORMAT /%u (%d).\n,
-   UVC_GUID_ARGS(info-entity), info-selector,
-   ret);
+   uvc_trace(UVC_TRACE_CONTROL,
+ GET_INFO failed on control %pUl/%u (%d).\n,
+ info-entity, info-selector, ret);
return;
}
 
flags = info-flags;
if (((flags  UVC_CONTROL_GET_CUR)  !(inf  (1  0))) ||
((flags  UVC_CONTROL_SET_CUR)  !(inf  (1  1 {
-   uvc_trace(UVC_TRACE_CONTROL, Control 
-   UVC_GUID_FORMAT /%u flags don't match 
-   supported operations.\n,
-   UVC_GUID_ARGS(info-entity), info-selector);
+   uvc_trace(UVC_TRACE_CONTROL,
+ Control %pUl/%u flags don't match supported 
operations.\n,
+ info-entity, info-selector);
return;
}
}
 
ctrl-info = info;
ctrl-data = kmalloc(ctrl-info-size * UVC_CTRL_NDATA, GFP_KERNEL);
-   uvc_trace(UVC_TRACE_CONTROL, Added control  UVC_GUID_FORMAT /%u 
-   to device %s entity %u\n, UVC_GUID_ARGS(ctrl-info-entity),
-   ctrl-info-selector, dev-udev-devpath, entity-id);
+   uvc_trace(UVC_TRACE_CONTROL,
+ Added control %pUl/%u to device %s entity %u\n,
+ ctrl-info-entity, ctrl-info-selector,
+ dev-udev-devpath, entity-id);
 }
 
 /*
@@ -1293,17 +1290,16 @@ int uvc_ctrl_add_info(struct uvc_control_info *info)
continue;
 
if (ctrl-selector == info-selector) {
-   uvc_trace(UVC_TRACE_CONTROL, Control 
-