Re: [PATCH 6/6] [media] pvrusb2: replace !0 with 1

2011-03-28 Thread Jarod Wilson
On Mar 26, 2011, at 12:37 AM, Mike Isely wrote: That's an opinion which I as the driver author disagree with. Strongly. How hard is it to read not false? Personally, I prefer use of true and false over both... On Sat, 26 Mar 2011, Dan Carpenter wrote: Using !0 is less readable than

[PATCH 6/6] [media] pvrusb2: replace !0 with 1

2011-03-25 Thread Dan Carpenter
Using !0 is less readable than just saying 1. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c b/drivers/media/video/pvrusb2/pvrusb2-std.c index 9bebc08..ca4f67b 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-std.c +++

Re: [PATCH 6/6] [media] pvrusb2: replace !0 with 1

2011-03-25 Thread Mike Isely
That's an opinion which I as the driver author disagree with. Strongly. How hard is it to read not false? Nacked-By: Mike Isely is...@pobox.com On Sat, 26 Mar 2011, Dan Carpenter wrote: Using !0 is less readable than just saying 1. Signed-off-by: Dan Carpenter erro...@gmail.com diff