Re: [PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-15 Thread Hans Verkuil
On Tuesday 16 June 2009 00:24:34 Karicheri, Muralidharan wrote: Hans, Please see my response below. snip A general remark: currently you link your inputs directly to a subdev. This approach has two disadvantages: 1) It doesn't work if there are no subdevs at all (e.g. because

Re: [PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-14 Thread Hans Verkuil
On Thursday 11 June 2009 19:00:46 m-kariche...@ti.com wrote: From: Muralidharan Karicheri a0868...@gt516km11.gt.design.ti.com DM355 platform and board setup This has platform and board setup changes to support vpfe capture driver for DM355 EVMs. Added registration of vpss platform

Re: [PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-14 Thread David Brownell
On Sunday 14 June 2009, Hans Verkuil wrote:   /* { I2C_BOARD_INFO(tlv320aic3x, 0x1b), }, */ Huh? What's this? I only know the tlv320aic23b and that's an audio driver. AIC33 is another audio codec chip: http://focus.ti.com/docs/prod/folders/print/tlv320aic33.html One can't list audio

[PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-11 Thread m-karicheri2
From: Muralidharan Karicheri a0868...@gt516km11.gt.design.ti.com DM355 platform and board setup This has platform and board setup changes to support vpfe capture driver for DM355 EVMs. Added registration of vpss platform driver based on last review Reviewed By Hans Verkuil. Reviewed By Laurent

Re: [PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-11 Thread David Brownell
On Thursday 11 June 2009, m-kariche...@ti.com wrote: +   I2C_BOARD_INFO(tvp5146, TVP5146_I2C_ADDR), Minor nit: just use 0x5d instead of defining TVP5146_I2C_ADDR. Fix in a v3, iff you make one. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a

[PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-09 Thread m-karicheri2
From: Muralidharan Karicheri a0868...@gt516km11.gt.design.ti.com DM355 platform and board setup This has platform and board setup changes to support vpfe capture driver for DM355 EVMs. Added registration of vpss platform driver based on last review Reviewed By Hans Verkuil. Reviewed By Laurent