Re: [PATCH 7/7] marvell-cam: Basic working MMP camera driver

2011-06-07 Thread Guennadi Liakhovetski
Not doing a full review, just a small nit-pick: On Mon, 6 Jun 2011, Jonathan Corbet wrote: Now we have a camera working over the marvell cam controller core. It works like the cafe driver and has all the same limitations, contiguous DMA only being one of them. But it's a start.

Re: [PATCH 7/7] marvell-cam: Basic working MMP camera driver

2011-06-07 Thread Jonathan Corbet
On Tue, 7 Jun 2011 09:44:45 +0200 (CEST) Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: +obj-$(CONFIG_VIDEO_MMP_CAMERA) += marvell-ccic/ Wouldn't it be better to have only one symbol, selecting the marvell-ccic directory in the Makefile and have all CAFE implementations select that

Re: [PATCH 7/7] marvell-cam: Basic working MMP camera driver

2011-06-07 Thread Guennadi Liakhovetski
On Tue, 7 Jun 2011, Jonathan Corbet wrote: On Tue, 7 Jun 2011 09:44:45 +0200 (CEST) Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: +obj-$(CONFIG_VIDEO_MMP_CAMERA) += marvell-ccic/ Wouldn't it be better to have only one symbol, selecting the marvell-ccic directory in the

[PATCH 7/7] marvell-cam: Basic working MMP camera driver

2011-06-06 Thread Jonathan Corbet
Now we have a camera working over the marvell cam controller core. It works like the cafe driver and has all the same limitations, contiguous DMA only being one of them. But it's a start. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/Makefile |1 +