Re: [PATCH RFC v3 1/3] V4L: Add driver for S3C244X/S3C64XX SoC series camera interface

Hi Sylwester, On Sat, Nov 17, 2012 at 2:39 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Alexey, On 11/16/2012 03:10 PM, Alexey Klimov wrote: +static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp *vp) +{ + unsigned int ip_rev =

Re: [PATCH RFC v3 1/3] V4L: Add driver for S3C244X/S3C64XX SoC series camera interface

Hi Hans, On 11/16/2012 02:45 PM, Hans Verkuil wrote: Hi Sylwester, Just one comment, see below... On Thu November 15 2012 23:05:13 Sylwester Nawrocki wrote: This patch adds V4L2 driver for Samsung S3C244X/S3C64XX SoC series camera interface. The driver exposes a subdev device node for CAMIF

Re: [PATCH RFC v3 1/3] V4L: Add driver for S3C244X/S3C64XX SoC series camera interface

Hi Sylwester, Just one comment, see below... On Thu November 15 2012 23:05:13 Sylwester Nawrocki wrote: This patch adds V4L2 driver for Samsung S3C244X/S3C64XX SoC series camera interface. The driver exposes a subdev device node for CAMIF pixel resolution and crop control and two video

Re: [PATCH RFC v3 1/3] V4L: Add driver for S3C244X/S3C64XX SoC series camera interface

Hi Sylwester, On Fri, Nov 16, 2012 at 2:05 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: This patch adds V4L2 driver for Samsung S3C244X/S3C64XX SoC series camera interface. The driver exposes a subdev device node for CAMIF pixel resolution and crop control and two video

Re: [PATCH RFC v3 1/3] V4L: Add driver for S3C244X/S3C64XX SoC series camera interface

Hi Alexey, On 11/16/2012 03:10 PM, Alexey Klimov wrote: +static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp *vp) +{ + unsigned int ip_rev = camif-variant-ip_revision; + unsigned long flags; + + if (camif-sensor.sd == NULL || vp-out_fmt == NULL) +