Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-10 Thread Hans Verkuil
On Wed October 10 2012 03:05:30 Mauro Carvalho Chehab wrote: Em Mon, 8 Oct 2012 15:03:36 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On Sun October 7 2012 13:13:36 Sylwester Nawrocki wrote: On 10/07/2012 03:19 AM, Michael West wrote: This patch changes versions.txt and disables

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-10 Thread Sylwester Nawrocki
On 10/10/2012 08:27 AM, Hans Verkuil wrote: diff --git a/drivers/media/i2c/m5mols/m5mols.h b/drivers/media/i2c/m5mols/m5mols.h index 4ab8b37..30654f5 100644 --- a/drivers/media/i2c/m5mols/m5mols.h +++ b/drivers/media/i2c/m5mols/m5mols.h @@ -24,7 +24,7 @@ * determined by

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-10 Thread Mauro Carvalho Chehab
Em Wed, 10 Oct 2012 08:27:26 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On Wed October 10 2012 03:05:30 Mauro Carvalho Chehab wrote: Em Mon, 8 Oct 2012 15:03:36 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On Sun October 7 2012 13:13:36 Sylwester Nawrocki wrote: On

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-10 Thread Hans Verkuil
On Wed 10 October 2012 12:39:39 Mauro Carvalho Chehab wrote: Em Wed, 10 Oct 2012 08:27:26 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On Wed October 10 2012 03:05:30 Mauro Carvalho Chehab wrote: Em Mon, 8 Oct 2012 15:03:36 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-10 Thread Mauro Carvalho Chehab
Em Wed, 10 Oct 2012 12:52:48 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On Wed 10 October 2012 12:39:39 Mauro Carvalho Chehab wrote: Em Wed, 10 Oct 2012 08:27:26 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On Wed October 10 2012 03:05:30 Mauro Carvalho Chehab wrote: Em

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-09 Thread Sylwester Nawrocki
Hi Laurent On 10/08/2012 10:42 PM, Laurent Pinchart wrote: Hi, When did the {get,set}_frame_desc subdev operations reach mainline ? Last I knew is that they were an RFC, and they're now suddenly in, without even one ack from an embedded v4l developer :-S I'm not totally happy with that.

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-09 Thread Mauro Carvalho Chehab
Em Mon, 8 Oct 2012 15:03:36 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On Sun October 7 2012 13:13:36 Sylwester Nawrocki wrote: On 10/07/2012 03:19 AM, Michael West wrote: This patch changes versions.txt and disables VIDEO_M5MOLS which fixed the build for my 3.2 kernel but looking

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-08 Thread Hans Verkuil
On Sun October 7 2012 13:13:36 Sylwester Nawrocki wrote: On 10/07/2012 03:19 AM, Michael West wrote: This patch changes versions.txt and disables VIDEO_M5MOLS which fixed the build for my 3.2 kernel but looking at the logs it looks like this is not the way to fix it as it's not just a

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-07 Thread Hans Verkuil
On Sun October 7 2012 03:19:48 Michael West wrote: This patch changes versions.txt and disables VIDEO_M5MOLS which fixed the build for my 3.2 kernel but looking at the logs it looks like this is not the way to fix it as it's not just a 3.6+ problem as it does not build on 3.6 as well...

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-07 Thread Sylwester Nawrocki
On 10/07/2012 03:19 AM, Michael West wrote: This patch changes versions.txt and disables VIDEO_M5MOLS which fixed the build for my 3.2 kernel but looking at the logs it looks like this is not the way to fix it as it's not just a 3.6+ problem as it does not build on 3.6 as well... So

Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-06 Thread Jan Hoogenraad
On my ubuntu 10.4 system Linux 2.6.32-43-generic-pae #97-Ubuntu SMP Wed Sep 5 16:59:17 UTC 2012 i686 GNU/Linux this patch breaks compilation of media_build. The constant SZ_1M is not defined in the includes on my system Do you know what can be done about this ? ---

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-06 Thread Sylwester Nawrocki
Hello Jan, On 10/06/2012 05:24 PM, Jan Hoogenraad wrote: On my ubuntu 10.4 system Linux 2.6.32-43-generic-pae #97-Ubuntu SMP Wed Sep 5 16:59:17 UTC 2012 i686 GNU/Linux this patch breaks compilation of media_build. The constant SZ_1M is not defined in the includes on my system Do you

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-06 Thread Jan Hoogenraad
Thanks. I see several drivers disabled for lower kernel versions in my Kconfig file. I am not sure how this is accomplished, but it would be helpful if the Fujitsu M-5MOLS 8MP sensor support is automatically disabled for kernel 3.6 I fixed it in my version by replacing SZ_1M by (1024*1024). I

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-06 Thread Sylwester Nawrocki
On 10/06/2012 08:43 PM, Jan Hoogenraad wrote: Thanks. I see several drivers disabled for lower kernel versions in my Kconfig file. I am not sure how this is accomplished, but it would be helpful if the Fujitsu M-5MOLS 8MP sensor support is automatically disabled for kernel 3.6 I fixed it in

RE: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-06 Thread Michael West
This patch changes versions.txt and disables VIDEO_M5MOLS which fixed the build for my 3.2 kernel but looking at the logs it looks like this is not the way to fix it as it's not just a 3.6+ problem as it does not build on 3.6 as well... So probably best to find why it doesn't build on the

[PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-09-26 Thread Sylwester Nawrocki
.get_frame_desc can be used by host interface driver to query properties of captured frames, e.g. required memory buffer size. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/i2c/m5mols/m5mols.h | 9 ++