RE: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-10 Thread Kaukab, Yousaf
ubject: Re: [PATCH v1] media: uvcvideo: handle urb completion in a work > queue > > On Wed, 9 Sep 2015, Laurent Pinchart wrote: > > > > > Instead of fixing the issue in the uvcvideo driver, would it then > > > > make more sense to fix it in the remaining h

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-09 Thread Laurent Pinchart
On Wednesday 09 September 2015 10:30:12 Hans de Goede wrote: > On 08-09-15 16:36, Alan Stern wrote: > > On Tue, 8 Sep 2015, Hans de Goede wrote: > >> On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: > >>> urb completion callback is executed in host controllers interrupt > >>> context. To keep

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-09 Thread Hans de Goede
Hi, On 08-09-15 16:36, Alan Stern wrote: On Tue, 8 Sep 2015, Hans de Goede wrote: Hi, On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: urb completion callback is executed in host controllers interrupt context. To keep preempt disable time short, add urbs to a list on completion and

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-09 Thread Alan Stern
On Wed, 9 Sep 2015, Laurent Pinchart wrote: > On Wednesday 09 September 2015 10:30:12 Hans de Goede wrote: > > On 08-09-15 16:36, Alan Stern wrote: > > > On Tue, 8 Sep 2015, Hans de Goede wrote: > > >> On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: > > >>> urb completion callback is executed

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-09 Thread Laurent Pinchart
Hi Alan, On Wednesday 09 September 2015 11:14:38 Alan Stern wrote: > On Wed, 9 Sep 2015, Laurent Pinchart wrote: > > On Wednesday 09 September 2015 10:30:12 Hans de Goede wrote: > >> On 08-09-15 16:36, Alan Stern wrote: > >>> On Tue, 8 Sep 2015, Hans de Goede wrote: > On 09/07/2015 06:23 PM,

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-09 Thread Alan Stern
On Wed, 9 Sep 2015, Laurent Pinchart wrote: > > > Instead of fixing the issue in the uvcvideo driver, would it then make > > > more sense to fix it in the remaining hcd drivers ? > > > > Unfortunately that's not so easy. It involves some subtle changes > > related to the way isochronous

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-09 Thread Alan Stern
On Wed, 9 Sep 2015, Hans de Goede wrote: > Hi, > > On 08-09-15 16:36, Alan Stern wrote: > > On Tue, 8 Sep 2015, Hans de Goede wrote: > > > >> Hi, > >> > >> On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: > >>> urb completion callback is executed in host controllers interrupt > >>> context. To

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-08 Thread Oliver Neukum
On Mon, 2015-09-07 at 18:23 +0200, Mian Yousaf Kaukab wrote: > urb completion callback is executed in host controllers interrupt > context. To keep preempt disable time short, add urbs to a list on > completion and schedule work to process the list. > > Moreover, save timestamp and sof number in

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-08 Thread Hans de Goede
Hi, On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: urb completion callback is executed in host controllers interrupt context. To keep preempt disable time short, add urbs to a list on completion and schedule work to process the list. Moreover, save timestamp and sof number in the urb

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-08 Thread Alan Stern
On Tue, 8 Sep 2015, Hans de Goede wrote: > Hi, > > On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: > > urb completion callback is executed in host controllers interrupt > > context. To keep preempt disable time short, add urbs to a list on > > completion and schedule work to process the list.

[PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-07 Thread Mian Yousaf Kaukab
urb completion callback is executed in host controllers interrupt context. To keep preempt disable time short, add urbs to a list on completion and schedule work to process the list. Moreover, save timestamp and sof number in the urb completion callback to avoid any delays. Signed-off-by: Mian