Re: [PATCH v2 13/48] tvp7002: Add pad-level DV timings operations

2014-03-11 Thread Prabhakar Lad
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
 The video enum_dv_timings operation is deprecated. Implement the
 pad-level version of the operation to prepare for the removal of the
 video version.

 Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
 Reviewed-by: Hans Verkuil hans.verk...@cisco.com

Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com

Regards,
--Prabhakar lad

 ---
  drivers/media/i2c/tvp7002.c | 4 
  1 file changed, 4 insertions(+)

 diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c
 index 912e1cc..9f56fd5 100644
 --- a/drivers/media/i2c/tvp7002.c
 +++ b/drivers/media/i2c/tvp7002.c
 @@ -832,6 +832,9 @@ static int tvp7002_log_status(struct v4l2_subdev *sd)
  static int tvp7002_enum_dv_timings(struct v4l2_subdev *sd,
 struct v4l2_enum_dv_timings *timings)
  {
 +   if (timings-pad != 0)
 +   return -EINVAL;
 +
 /* Check requested format index is within range */
 if (timings-index = NUM_TIMINGS)
 return -EINVAL;
 @@ -937,6 +940,7 @@ static const struct v4l2_subdev_pad_ops tvp7002_pad_ops = 
 {
 .enum_mbus_code = tvp7002_enum_mbus_code,
 .get_fmt = tvp7002_get_pad_format,
 .set_fmt = tvp7002_set_pad_format,
 +   .enum_dv_timings = tvp7002_enum_dv_timings,
  };

  /* V4L2 top level operation handlers */
 --
 1.8.3.2

 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 13/48] tvp7002: Add pad-level DV timings operations

2014-03-10 Thread Laurent Pinchart
The video enum_dv_timings operation is deprecated. Implement the
pad-level version of the operation to prepare for the removal of the
video version.

Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
 drivers/media/i2c/tvp7002.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c
index 912e1cc..9f56fd5 100644
--- a/drivers/media/i2c/tvp7002.c
+++ b/drivers/media/i2c/tvp7002.c
@@ -832,6 +832,9 @@ static int tvp7002_log_status(struct v4l2_subdev *sd)
 static int tvp7002_enum_dv_timings(struct v4l2_subdev *sd,
struct v4l2_enum_dv_timings *timings)
 {
+   if (timings-pad != 0)
+   return -EINVAL;
+
/* Check requested format index is within range */
if (timings-index = NUM_TIMINGS)
return -EINVAL;
@@ -937,6 +940,7 @@ static const struct v4l2_subdev_pad_ops tvp7002_pad_ops = {
.enum_mbus_code = tvp7002_enum_mbus_code,
.get_fmt = tvp7002_get_pad_format,
.set_fmt = tvp7002_set_pad_format,
+   .enum_dv_timings = tvp7002_enum_dv_timings,
 };
 
 /* V4L2 top level operation handlers */
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html