Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

2017-02-16 Thread Antti Palosaari
On 02/16/2017 10:48 AM, Antti Palosaari wrote: On 02/16/2017 01:31 AM, Stefan Bruens wrote: +/* attach demod */ +memset(&si2168_config, 0, sizeof(si2168_config)); prefer sizeof dst You mean sizeof(struct si2168_config) ? yeah. See chapter 14 from kernel coding style documentation

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

2017-02-16 Thread Antti Palosaari
Hello On 02/16/2017 01:31 AM, Stefan Bruens wrote: Hi Antti, first thanks for for the review. Note the t230c_attach is mostly a copy of the t330_attach (which is very similar to the t680c_attach), so any of your comments should probably applied to the other attach functions to have a common cod

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

2017-02-15 Thread Stefan Bruens
Hi Antti, first thanks for for the review. Note the t230c_attach is mostly a copy of the t330_attach (which is very similar to the t680c_attach), so any of your comments should probably applied to the other attach functions to have a common coding style. On Mittwoch, 15. Februar 2017 10:27:09

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

2017-02-15 Thread Antti Palosaari
On 02/15/2017 03:51 AM, Stefan Brüns wrote: Mygica T230 DVB-T/T2/C USB stick support. It uses the same FX2/Si2168 bridge/demodulator combo as the other devices supported by the driver, but uses the Si2141 tuner. Several DVB-T (MPEG2) and DVB-T2 (H.265) channels were tested, as well as the include

[PATCH v2 3/3] [media] dvbsky: MyGica T230C support

2017-02-14 Thread Stefan Brüns
Mygica T230 DVB-T/T2/C USB stick support. It uses the same FX2/Si2168 bridge/demodulator combo as the other devices supported by the driver, but uses the Si2141 tuner. Several DVB-T (MPEG2) and DVB-T2 (H.265) channels were tested, as well as the include remote control. Signed-off-by: Stefan Brüns