Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-09-02 Thread Sean Young
On Fri, Sep 02, 2016 at 02:27:08PM +0900, Andi Shyti wrote: > > Thanks Andi, this is looking great! > > Thanks Sean! With your reviews the whole thing looks much better > now :) > > I agree with all your points here, I will fix them. Can I add > your reviewd-by? Yes, please add it to this

Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-09-01 Thread Andi Shyti
> Thanks Andi, this is looking great! Thanks Sean! With your reviews the whole thing looks much better now :) I agree with all your points here, I will fix them. Can I add your reviewd-by? Thanks, Andi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a

[PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-09-01 Thread Andi Shyti
The ir-spi is a simple device driver which supports the connection between an IR LED and the MOSI line of an SPI device. The driver, indeed, uses the SPI framework to stream the raw data provided by userspace through an rc character device. The chardev is handled by the LIRC framework and its

Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-09-01 Thread Sean Young
Thanks Andi, this is looking great! On Fri, Sep 02, 2016 at 02:16:29AM +0900, Andi Shyti wrote: > The ir-spi is a simple device driver which supports the > connection between an IR LED and the MOSI line of an SPI device. > > The driver, indeed, uses the SPI framework to stream the raw data >