[PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ...

Re: [PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree()

2012-09-12 Thread Marcos Souza
2012/9/12 Peter Senna Tschudin peter.se...@gmail.com: From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position

Re: [PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
Marcos, Now that you removed this kfree, you could remove this label too. Very nice your cleanup :) Thanks! vpbe_fail_sd_register: kfree(vpbe_dev-encoders); vpbe_fail_v4l2_device: The problem removing the label is that it will require some more work naming the labels. See: if

Re: [PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree()

2012-09-12 Thread Marcos Souza
Hi Peter, 2012/9/12 Peter Senna Tschudin peter.se...@gmail.com: Marcos, Now that you removed this kfree, you could remove this label too. Very nice your cleanup :) Thanks! vpbe_fail_sd_register: kfree(vpbe_dev-encoders); vpbe_fail_v4l2_device: The problem removing the label

Re: [PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree()

2012-09-12 Thread Dan Carpenter
On Wed, Sep 12, 2012 at 05:50:54PM +0200, Peter Senna Tschudin wrote: Marcos, Now that you removed this kfree, you could remove this label too. Very nice your cleanup :) Thanks! vpbe_fail_sd_register: kfree(vpbe_dev-encoders); vpbe_fail_v4l2_device: The problem