Re: [PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-21 Thread Daniel Glöckner
Hi Bob, On Thu, Apr 21, 2011 at 11:17:42AM +0800, Bob Liu wrote: +#ifdef CONFIG_MMU if (i == queue-count || size != queue-buf_size) { +#else + if (i == queue-count || PAGE_ALIGN(size) != queue-buf_size) { +#endif on mmu systems do_mmap_pgoff contains a len = PAGE_ALIGN(len); line.

Re: [PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-21 Thread Bob Liu
On Thu, Apr 21, 2011 at 3:59 PM, Daniel Glöckner daniel...@gmx.net wrote: Hi Bob, On Thu, Apr 21, 2011 at 11:17:42AM +0800, Bob Liu wrote: +#ifdef CONFIG_MMU       if (i == queue-count || size != queue-buf_size) { +#else +     if (i == queue-count || PAGE_ALIGN(size) != queue-buf_size) {

Re: [PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-21 Thread Daniel Glöckner
On Thu, Apr 21, 2011 at 04:20:36PM +0800, Bob Liu wrote: on mmu systems do_mmap_pgoff contains a len = PAGE_ALIGN(len); line. If we depend on this behavior, why not do it here as well and get rid of the #ifdef? If do it in do_mmap_pgoff() the whole system will be effected, I am not

Re: [PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-21 Thread Bob Liu
On Thu, Apr 21, 2011 at 5:47 PM, Daniel Glöckner daniel...@gmx.net wrote: On Thu, Apr 21, 2011 at 04:20:36PM +0800, Bob Liu wrote: on mmu systems do_mmap_pgoff contains a len = PAGE_ALIGN(len); line. If we depend on this behavior, why not do it here as well and get rid of the #ifdef? If

Re: [PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-21 Thread Daniel Glöckner
On Thu, Apr 21, 2011 at 05:57:31PM +0800, Bob Liu wrote: On Thu, Apr 21, 2011 at 5:47 PM, Daniel Glöckner daniel...@gmx.net wrote: On Thu, Apr 21, 2011 at 04:20:36PM +0800, Bob Liu wrote: on mmu systems do_mmap_pgoff contains a len = PAGE_ALIGN(len); line. If we depend on this behavior,

[PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-20 Thread Bob Liu
UVC driver used to have partial no-mmu arch support, but it's removed by commit c29fcff3daafbf46d64a543c1950bbd206ad8c1c. This patch added them back and expanded to fully support no-mmu arch, so that uvc cameras can be used on no-mmu platforms like Blackfin. Signed-off-by: Bob Liu