Re: [PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-06-06 Thread Tomasz Stanislawski
On 05/22/2012 10:10 PM, Andrew Morton wrote: On Mon, 21 May 2012 16:01:50 +0200 Tomasz Stanislawski t.stanisl...@samsung.com wrote: +int sg_alloc_table_from_pages(struct sg_table *sgt, + struct page **pages, unsigned int n_pages, + unsigned long offset, unsigned long size, + gfp_t

Re: [PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-05-22 Thread Andrew Morton
On Mon, 21 May 2012 16:01:50 +0200 Tomasz Stanislawski t.stanisl...@samsung.com wrote: +int sg_alloc_table_from_pages(struct sg_table *sgt, + struct page **pages, unsigned int n_pages, + unsigned long offset, unsigned long size, + gfp_t gfp_mask) I guess a 32-bit n_pages is OK. A

Re: [PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-05-21 Thread Tomasz Stanislawski
Hi Andrew, Thank you for your review, Please refer to the comments below. On 05/18/2012 01:56 AM, Andrew Morton wrote: On Tue, 08 May 2012 11:50:33 +0200 Tomasz Stanislawski t.stanisl...@samsung.com wrote: This patch adds a new constructor for an sg table. The table is constructed from an

[PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-05-08 Thread Tomasz Stanislawski
This patch adds a new constructor for an sg table. The table is constructed from an array of struct pages. All contiguous chunks of the pages are merged into a single sg nodes. A user may provide an offset and a size of a buffer if the buffer is not page-aligned. The function is dedicated for

Re: [PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-05-08 Thread Daniel Vetter
On Tue, May 08, 2012 at 11:50:33AM +0200, Tomasz Stanislawski wrote: This patch adds a new constructor for an sg table. The table is constructed from an array of struct pages. All contiguous chunks of the pages are merged into a single sg nodes. A user may provide an offset and a size of a

Re: [PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-05-08 Thread Laurent Pinchart
Hi Tomasz, Thank you for the patch. On Tuesday 08 May 2012 11:50:33 Tomasz Stanislawski wrote: This patch adds a new constructor for an sg table. The table is constructed from an array of struct pages. All contiguous chunks of the pages are merged into a single sg nodes. A user may provide an