Re: [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor

Hi Pali, On Sat, Jun 18, 2016 at 05:37:33PM +0200, Pali Rohár wrote: > On Saturday 18 June 2016 17:22:59 Pavel Machek wrote: > > > +/* > > > + * > > > + * Stingray sensor mode settings for Scooby > > > + * > > > + * > > > + */ > > > > I'd fix it to normal comment style... and possibly remove it.

Re: [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor

On Saturday 18 June 2016 18:04:23 Pavel Machek wrote: > Hi! > > > > > + .reglist = { > > > > + { .ptr = _poweron_mode2_16vga_2592x1968_12_07fps > > > > }, > > > > + { .ptr = _16vga_2592x1968_13_12fps_dpcm10_8 }, > > > > + { .ptr =

Re: [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor

Hi! > > > + .reglist = { > > > + { .ptr = _poweron_mode2_16vga_2592x1968_12_07fps }, > > > + { .ptr = _16vga_2592x1968_13_12fps_dpcm10_8 }, > > > + { .ptr = _4vga_1296x984_29_99fps_dpcm10_8 }, > > > + { .ptr = _svga_864x656_29_88fps }, > > > + { .ptr =

Re: [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor

On Saturday 18 June 2016 17:22:59 Pavel Machek wrote: > > +/* > > + * > > + * Stingray sensor mode settings for Scooby > > + * > > + * > > + */ > > I'd fix it to normal comment style... and possibly remove it. Can you > understand what it says? > > > + }, > > + .regs = { > > + {

Re: [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor

Hi! > The sensor is found in Nokia N900 main camera > > Signed-off-by: Ivaylo Dimitrov > +/* > + * > + * Register access helpers > + * > + */ > + > +/* > + * Read a 8/16/32-bit i2c register. The value is returned in 'val'. > + * Returns zero if successful, or

[PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor

The sensor is found in Nokia N900 main camera Signed-off-by: Ivaylo Dimitrov --- drivers/media/i2c/Kconfig|1 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/et8ek8/Kconfig |6 +