Re: [PATCH v3 3/6] SoC Camera: add driver for OV6650 sensor

2010-10-02 Thread Guennadi Liakhovetski
On Sat, 2 Oct 2010, Janusz Krzysztofik wrote: > Saturday 02 October 2010 07:47:47 Guennadi Liakhovetski napisał(a): > > Ok, let's take this one, but, please, address the below couple of minor > > issues in an incremental patch. > > > > On Mon, 27 Sep 2010, Janusz Krzysztofik wrote: > > > +/* writ

Re: [PATCH v3 3/6] SoC Camera: add driver for OV6650 sensor

2010-10-02 Thread Janusz Krzysztofik
Saturday 02 October 2010 07:47:47 Guennadi Liakhovetski napisał(a): > Ok, let's take this one, but, please, address the below couple of minor > issues in an incremental patch. > > On Mon, 27 Sep 2010, Janusz Krzysztofik wrote: > > +/* write a register */ > > +static int ov6650_reg_write(struct i2c_

Re: [PATCH v3 3/6] SoC Camera: add driver for OV6650 sensor

2010-10-01 Thread Guennadi Liakhovetski
Ok, let's take this one, but, please, address the below couple of minor issues in an incremental patch. On Mon, 27 Sep 2010, Janusz Krzysztofik wrote: > +/* write a register */ > +static int ov6650_reg_write(struct i2c_client *client, u8 reg, u8 val) > +{ > + int ret; > + unsigned char d

[PATCH v3 3/6] SoC Camera: add driver for OV6650 sensor

2010-09-26 Thread Janusz Krzysztofik
This patch provides a V4L2 SoC Camera driver for OV6650 camera sensor, found on OMAP1 SoC based Amstrad Delta videophone. Since I have no experience with camera sensors, and the sensor documentation I was able to find was not very comprehensive, I left most settings at their default (reset) val