Hi Sakari, Thanks for review.
On 24.07.2018 15:52, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 23, 2018 at 02:02:52PM +0300, Todor Tomov wrote: >> This removes warning "Unknown pixelformat" for the following formats: >> V4L2_PIX_FMT_SBGGR14P >> V4L2_PIX_FMT_SGBRG14P >> V4L2_PIX_FMT_SGRBG14P >> V4L2_PIX_FMT_SRGGB14P >> >> CC: Sakari Ailus <sakari.ai...@linux.intel.com> >> Signed-off-by: Todor Tomov <todor.to...@linaro.org> >> --- >> drivers/media/v4l2-core/v4l2-ioctl.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c >> b/drivers/media/v4l2-core/v4l2-ioctl.c >> index 2e3b1f0..e8f7c89 100644 >> --- a/drivers/media/v4l2-core/v4l2-ioctl.c >> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c >> @@ -1260,6 +1260,10 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) >> case V4L2_PIX_FMT_SGBRG12P: descr = "12-bit Bayer GBGB/RGRG >> Packed"; break; >> case V4L2_PIX_FMT_SGRBG12P: descr = "12-bit Bayer GRGR/BGBG >> Packed"; break; >> case V4L2_PIX_FMT_SRGGB12P: descr = "12-bit Bayer RGRG/GBGB >> Packed"; break; >> + case V4L2_PIX_FMT_SBGGR14P: descr = "14-bit Bayer BGBG/GRGR >> Packed"; break; >> + case V4L2_PIX_FMT_SGBRG14P: descr = "14-bit Bayer GBGB/RGRG >> Packed"; break; >> + case V4L2_PIX_FMT_SGRBG14P: descr = "14-bit Bayer GRGR/BGBG >> Packed"; break; >> + case V4L2_PIX_FMT_SRGGB14P: descr = "14-bit Bayer RGRG/GBGB >> Packed"; break; >> case V4L2_PIX_FMT_SBGGR16: descr = "16-bit Bayer BGBG/GRGR"; break; >> case V4L2_PIX_FMT_SGBRG16: descr = "16-bit Bayer GBGB/RGRG"; break; >> case V4L2_PIX_FMT_SGRBG16: descr = "16-bit Bayer GRGR/BGBG"; break; > > You could merge this to the patch that adds the format definitions. Or: Yes. I think we are going to have v4 so I will merge it with the patch which adds the format definitions. > > Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> > > And preferrably move it to earlier in the patchset where new formats are > added. > -- Best regards, Todor Tomov
