Re: [PATCH v3 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-09 Thread Laurent Pinchart
Hi Sakari, On Thursday 08 March 2012 19:17:46 Sakari Ailus wrote: On Wed, Mar 07, 2012 at 12:31:34PM +0100, Laurent Pinchart wrote: [snip] +static int mt9m032_set_frame_interval(struct v4l2_subdev *subdev, + struct v4l2_subdev_frame_interval

Re: [PATCH v3 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-08 Thread Sakari Ailus
Hi Laurent, On Wed, Mar 07, 2012 at 12:31:34PM +0100, Laurent Pinchart wrote: ... +static u32 mt9m032_row_time(struct mt9m032 *sensor, unsigned int width) +{ + unsigned int effective_width; + u32 ns; + + effective_width = width + 716; /* emperical value */ Why empirical

Re: [PATCH v3 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-07 Thread Laurent Pinchart
Hi Sakari, On Wednesday 07 March 2012 01:16:33 Sakari Ailus wrote: Hi Laurent, Thanks for the patch. I have a few comments below. Just one fairly general question: locking. Shouldn't you serialise accesses to sensor registers and your data, possibly by using a mutex? I guess I should,

[PATCH v3 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-06 Thread Laurent Pinchart
From: Martin Hostettler mar...@neutronstar.dyndns.org The MT9M032 is a parallel 1.6MP sensor from Micron controlled through I2C. The driver creates a V4L2 subdevice. It currently supports cropping, gain, exposure and v/h flipping controls in monochrome mode with an external pixel clock.

Re: [PATCH v3 5/5] v4l: Add driver for Micron MT9M032 camera sensor

2012-03-06 Thread Sakari Ailus
Hi Laurent, Thanks for the patch. I have a few comments below. Just one fairly general question: locking. Shouldn't you serialise accesses to sensor registers and your data, possibly by using a mutex? Laurent Pinchart wrote: From: Martin Hostettler mar...@neutronstar.dyndns.org The MT9M032