Re: [PATCH v4] uvcvideo: add a metadata device node

2017-07-28 Thread Laurent Pinchart
Hi Guennadi, On Friday 28 Jul 2017 10:59:29 Guennadi Liakhovetski wrote: > On Fri, 28 Jul 2017, Laurent Pinchart wrote: > > On Tuesday 25 Jul 2017 15:27:24 Guennadi Liakhovetski wrote: > >> On Fri, 21 Jul 2017, Laurent Pinchart wrote: > >>> Hi Guennadi, > >>> > >>> Thank you for the patch. > >>>

Re: [PATCH v4] uvcvideo: add a metadata device node

2017-07-28 Thread Guennadi Liakhovetski
Hi Laurent, On Fri, 28 Jul 2017, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday 25 Jul 2017 15:27:24 Guennadi Liakhovetski wrote: > > On Fri, 21 Jul 2017, Laurent Pinchart wrote: > > > Hi Guennadi, > > > > > > Thank you for the patch. > > > > > >> Some UVC video cameras contain

Re: [PATCH v4] uvcvideo: add a metadata device node

2017-07-27 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 25 Jul 2017 15:27:24 Guennadi Liakhovetski wrote: > On Fri, 21 Jul 2017, Laurent Pinchart wrote: > > Hi Guennadi, > > > > Thank you for the patch. > > > >> Some UVC video cameras contain metadata in their payload headers. This > >> patch extracts that data, adding more

Re: [PATCH v4] uvcvideo: add a metadata device node

2017-07-26 Thread Hans Verkuil
On 07/26/17 14:29, Guennadi Liakhovetski wrote: > On Tue, 25 Jul 2017, Guennadi Liakhovetski wrote: > > [snip] > +struct uvc_meta_buf { + struct timespec ts; >>> >>> timespec has a different size on 32-bit and 64-bit architectures, so there >>> could be issues on 32-bit userspace

Re: [PATCH v4] uvcvideo: add a metadata device node

2017-07-26 Thread Guennadi Liakhovetski
On Tue, 25 Jul 2017, Guennadi Liakhovetski wrote: [snip] > > > +struct uvc_meta_buf { > > > + struct timespec ts; > > > > timespec has a different size on 32-bit and 64-bit architectures, so there > > could be issues on 32-bit userspace running on a 64-bit kernel. > > > > Additionally, on

Re: [PATCH v4] uvcvideo: add a metadata device node

2017-07-25 Thread Guennadi Liakhovetski
Hi Laurent, Thanks for your comments! On Fri, 21 Jul 2017, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > > Some UVC video cameras contain metadata in their payload headers. This > > patch extracts that data, adding more clock synchronisation information, > > on both

Re: [PATCH v4] uvcvideo: add a metadata device node

2017-07-21 Thread Laurent Pinchart
Hi Guennadi, Thank you for the patch. > Some UVC video cameras contain metadata in their payload headers. This > patch extracts that data, adding more clock synchronisation information, > on both bulk and isochronous endpoints and makes it available to the > user space on a separate video node,

[PATCH v4] uvcvideo: add a metadata device node

2017-07-07 Thread Guennadi Liakhovetski
Some UVC video cameras contain metadata in their payload headers. This patch extracts that data, adding more clock synchronisation information, on both bulk and isochronous endpoints and makes it available to the user space on a separate video node, using the V4L2_CAP_META_CAPTURE capability and