Re: [PATCH v4 02/14] media: ov772x: correct setting of banding filter

2018-05-03 Thread jacopo mondi
Hi Akinobu, thanks for the patch On Mon, Apr 30, 2018 at 02:13:01AM +0900, Akinobu Mita wrote: > The banding filter ON/OFF is controlled via bit 5 of COM8 register. It > is attempted to be enabled in ov772x_set_params() by the following line. > > ret = ov772x_mask_set(client, COM8,

[PATCH v4 02/14] media: ov772x: correct setting of banding filter

2018-04-29 Thread Akinobu Mita
The banding filter ON/OFF is controlled via bit 5 of COM8 register. It is attempted to be enabled in ov772x_set_params() by the following line. ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, 1); But this unexpectedly results disabling the banding filter, because the mask and set bits