Re: [PATCH v4 RFC 1/2] [media] em28xx: retry I2C write ops if failed by timeout

2014-01-05 Thread Frank Schäfer
Am 04.01.2014 18:58, schrieb Markus Rechberger: > Did you trace the i2c messages on the bus? This seems like papering > the actual bug. The USB traces are clear: i2c status 0x10 is treated as _final_ i2c transfer status and the driver does _not_ retry. Yes, it's papering over the actual bug. We ne

Re: [PATCH v4 RFC 1/2] [media] em28xx: retry I2C write ops if failed by timeout

2014-01-04 Thread Markus Rechberger
Did you trace the i2c messages on the bus? This seems like papering the actual bug. USB 3.0 is a disaster with Linux, maybe your hardware or your controller driver is not okay? There are other bugreports out there which are USB 3.0 related, some of our customers reported that since 3.6.0 is okay w

[PATCH v4 RFC 1/2] [media] em28xx: retry I2C write ops if failed by timeout

2014-01-04 Thread Mauro Carvalho Chehab
At least on HVR-950, sometimes an I2C operation fails. This seems to be more frequent when the device is connected into an USB 3.0 port. Instead of report an error, try to repeat it, for up to 20 ms. That makes the code more reliable. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/