Re: [PATCH v5] media: imx: add mem2mem device

2019-01-14 Thread Nicolas Dufresne
Le mardi 08 janvier 2019 à 16:30 +0100, Philipp Zabel a écrit : > > # To demonstrate (with patched gst-plugins-bad > > https://paste.fedoraproject.org/paste/rs-CbEq7coL4XSKrnWpEDw) > > gst-launch-1.0 videotestsrc ! video/x-raw,format=YUY2 ! v4l2convert ! > > video/x-raw,format=xRGB ! kmssink > >

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-08 Thread Nicolas Dufresne
Le mardi 08 janvier 2019 à 16:30 +0100, Philipp Zabel a écrit : > Hi Nicolas, > > On Mon, 2019-01-07 at 17:36 -0500, Nicolas Dufresne wrote: > > Le lundi 03 décembre 2018 à 12:48 +0100, Philipp Zabel a écrit : > > > Add a single imx-media mem2mem video device that uses the IPU IC PP > > > (image c

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-08 Thread Philipp Zabel
Hi Hans, On Wed, 2018-12-05 at 19:50 +0100, Hans Verkuil wrote: > On 12/05/2018 02:20 AM, Steve Longerbeam wrote: > > Hi Hans, Philipp, > > > > One comment on my side... > > > > On 12/3/18 7:21 AM, Hans Verkuil wrote: > > > > > > > +void imx_media_mem2mem_device_unregister(struct imx_media_vide

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-08 Thread Philipp Zabel
Hi Steve, On Tue, 2018-12-04 at 17:20 -0800, Steve Longerbeam wrote: > Hi Hans, Philipp, > > One comment on my side... > > On 12/3/18 7:21 AM, Hans Verkuil wrote: > > > > > +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev > > > *vdev) > > > +{ > > > + struct mem2mem_priv *p

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-08 Thread Philipp Zabel
Hi Hans, thank you for your comments! On Mon, 2018-12-03 at 16:21 +0100, Hans Verkuil wrote: > On 12/03/2018 12:48 PM, Philipp Zabel wrote: > > Add a single imx-media mem2mem video device that uses the IPU IC PP > > (image converter post processing) task for scaling and colorspace > > conversion.

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-08 Thread Philipp Zabel
Hi Nicolas, On Mon, 2019-01-07 at 17:36 -0500, Nicolas Dufresne wrote: > Le lundi 03 décembre 2018 à 12:48 +0100, Philipp Zabel a écrit : > > Add a single imx-media mem2mem video device that uses the IPU IC PP > > (image converter post processing) task for scaling and colorspace > > conversion. >

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-07 Thread Nicolas Dufresne
Le lundi 03 décembre 2018 à 12:48 +0100, Philipp Zabel a écrit : > Add a single imx-media mem2mem video device that uses the IPU IC PP > (image converter post processing) task for scaling and colorspace > conversion. > On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. > > The h

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-06 Thread Steve Longerbeam
Hi Hans, On 12/6/18 4:32 AM, Hans Verkuil wrote: On 12/06/18 00:13, Steve Longerbeam wrote: On 12/5/18 10:50 AM, Hans Verkuil wrote: On 12/05/2018 02:20 AM, Steve Longerbeam wrote: Hi Hans, Philipp, One comment on my side... On 12/3/18 7:21 AM, Hans Verkuil wrote: +void imx_media_mem2me

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-06 Thread Hans Verkuil
On 12/06/18 00:13, Steve Longerbeam wrote: > > > On 12/5/18 10:50 AM, Hans Verkuil wrote: >> On 12/05/2018 02:20 AM, Steve Longerbeam wrote: >>> Hi Hans, Philipp, >>> >>> One comment on my side... >>> >>> On 12/3/18 7:21 AM, Hans Verkuil wrote: > +void imx_media_mem2mem_device_unregiste

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-05 Thread Steve Longerbeam
On 12/5/18 10:50 AM, Hans Verkuil wrote: On 12/05/2018 02:20 AM, Steve Longerbeam wrote: Hi Hans, Philipp, One comment on my side... On 12/3/18 7:21 AM, Hans Verkuil wrote: +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev) +{ + struct mem2mem_priv *priv =

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-05 Thread Hans Verkuil
On 12/05/2018 02:20 AM, Steve Longerbeam wrote: > Hi Hans, Philipp, > > One comment on my side... > > On 12/3/18 7:21 AM, Hans Verkuil wrote: >> >>> +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev) >>> +{ >>> + struct mem2mem_priv *priv = to_mem2mem_priv(vdev); >>> +

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-04 Thread Steve Longerbeam
Hi Hans, Philipp, One comment on my side... On 12/3/18 7:21 AM, Hans Verkuil wrote: +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev) +{ + struct mem2mem_priv *priv = to_mem2mem_priv(vdev); + struct video_device *vfd = priv->vdev.vfd; + + mutex_lock

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-03 Thread Hans Verkuil
On 12/03/2018 12:48 PM, Philipp Zabel wrote: > Add a single imx-media mem2mem video device that uses the IPU IC PP > (image converter post processing) task for scaling and colorspace > conversion. > On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. > > The hardware only support

[PATCH v5] media: imx: add mem2mem device

2018-12-03 Thread Philipp Zabel
Add a single imx-media mem2mem video device that uses the IPU IC PP (image converter post processing) task for scaling and colorspace conversion. On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. The hardware only supports writing to destination buffers up to 1024x1024 pixels i