Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-24 Thread Joe Perches
On Tue, 2013-09-24 at 14:52 +0200, Tomasz Stanislawski wrote: > On 09/23/2013 07:44 PM, Joe Perches wrote: > > On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote: > >> On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: > >>> May I ask what is the rationale for this

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-24 Thread Bartlomiej Zolnierkiewicz
Hi Tomasz, On Tuesday, September 24, 2013 02:52:44 PM Tomasz Stanislawski wrote: > On 09/23/2013 07:44 PM, Joe Perches wrote: > > On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote: > >> On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: > >>> May I ask what is t

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-24 Thread Mauro Carvalho Chehab
Em Tue, 24 Sep 2013 12:33:34 +0200 Bartlomiej Zolnierkiewicz escreveu: > > Hi Tomasz, > > On Tuesday, September 24, 2013 11:43:53 AM Tomasz Stanislawski wrote: > > Hi, > > > > On 09/23/2013 05:48 PM, Bartlomiej Zolnierkiewicz wrote: > > > > > > Hi Tomasz, > > > > > > On Monday, September 23,

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-24 Thread Tomasz Stanislawski
On 09/23/2013 07:44 PM, Joe Perches wrote: > On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote: >> On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: >>> May I ask what is the rationale for this patch? >>> To reduce a few lines of code? >> This patch makes source

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-24 Thread Bartlomiej Zolnierkiewicz
Hi Tomasz, On Tuesday, September 24, 2013 11:43:53 AM Tomasz Stanislawski wrote: > Hi, > > On 09/23/2013 05:48 PM, Bartlomiej Zolnierkiewicz wrote: > > > > Hi Tomasz, > > > > On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: > >> Hello, > >> May I ask what is the rationale f

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-24 Thread Tomasz Stanislawski
Hi, On 09/23/2013 05:48 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi Tomasz, > > On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: >> Hello, >> May I ask what is the rationale for this patch? >> To reduce a few lines of code? > > This patch makes source code more generic-like

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-23 Thread Joe Perches
On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote: > On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: > > May I ask what is the rationale for this patch? > > To reduce a few lines of code? > This patch makes source code more generic-like and easier to follow (mx

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-23 Thread Bartlomiej Zolnierkiewicz
Hi Tomasz, On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: > Hello, > May I ask what is the rationale for this patch? > To reduce a few lines of code? This patch makes source code more generic-like and easier to follow (mxd_r* macros currently only obfuscate the code and mak

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-23 Thread Tomasz Stanislawski
Hello, May I ask what is the rationale for this patch? To reduce a few lines of code? Or to give up possibility of changing message format in just one place? I could see migrating from mxr_* to pr_* could seen as the fix, but not this. Waiting for reply, Tomasz Stanislawski On 09/21/2013 05:00

[PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-21 Thread Mateusz Krawczuk
Replace mxr_dbg, mxr_info and mxr_warn by generic solution. Signed-off-by: Mateusz Krawczuk Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-tv/mixer.h | 12 --- drivers/media/platform/s5p-tv/mixer_drv.c | 47 ++- drivers/media/platform/s5p-tv/mixer_grp_laye