Re: [PATCH v5 12/14] media: ov772x: avoid accessing registers under power saving mode

2018-05-14 Thread jacopo mondi
Hi Sakari, thanks for the clarification, please ignore my comment then. Thanks j On Mon, May 14, 2018 at 12:49:19PM +0300, Sakari Ailus wrote: > Hi Jacopo, > > On Mon, May 14, 2018 at 11:06:46AM +0200, jacopo mondi wrote: > > Hi Akinobu, > > > >a small nit below > > > > On Sun, May 06,

Re: [PATCH v5 12/14] media: ov772x: avoid accessing registers under power saving mode

2018-05-14 Thread Sakari Ailus
Hi Jacopo, On Mon, May 14, 2018 at 11:06:46AM +0200, jacopo mondi wrote: > Hi Akinobu, > >a small nit below > > On Sun, May 06, 2018 at 11:19:27PM +0900, Akinobu Mita wrote: > > The set_fmt() in subdev pad ops, the s_ctrl() for subdev control handler, > > and the s_frame_interval() in

Re: [PATCH v5 12/14] media: ov772x: avoid accessing registers under power saving mode

2018-05-14 Thread jacopo mondi
Hi Akinobu, a small nit below On Sun, May 06, 2018 at 11:19:27PM +0900, Akinobu Mita wrote: > The set_fmt() in subdev pad ops, the s_ctrl() for subdev control handler, > and the s_frame_interval() in subdev video ops could be called when the > device is under power saving mode. These

[PATCH v5 12/14] media: ov772x: avoid accessing registers under power saving mode

2018-05-06 Thread Akinobu Mita
The set_fmt() in subdev pad ops, the s_ctrl() for subdev control handler, and the s_frame_interval() in subdev video ops could be called when the device is under power saving mode. These callbacks for ov772x driver cause updating H/W registers that will fail under power saving mode. This avoids