Re: [PATCH v5 5/6] V4L: Events: Support event handling in do_ioctl

2010-02-22 Thread Sakari Ailus
Hans Verkuil wrote: > There is a crucial piece of functionality missing here: if the > filehandle is in blocking mode, then it should wait until an event > arrives. That also means that if vfh->events == NULL, you should >>> still > call v4l2_event_dequeue, and that function should

Re: [PATCH v5 5/6] V4L: Events: Support event handling in do_ioctl

2010-02-22 Thread Hans Verkuil
> Hi Hans, > > On Monday 22 February 2010 08:53:53 Hans Verkuil wrote: >> On Sunday 21 February 2010 23:31:43 Sakari Ailus wrote: >> > Hans Verkuil wrote: >> > > More comments... >> > > >> > > On Friday 19 February 2010 20:21:59 Sakari Ailus wrote: >> > >> Add support for event handling to do_ioct

Re: [PATCH v5 5/6] V4L: Events: Support event handling in do_ioctl

2010-02-22 Thread Laurent Pinchart
Hi Hans, On Monday 22 February 2010 08:53:53 Hans Verkuil wrote: > On Sunday 21 February 2010 23:31:43 Sakari Ailus wrote: > > Hans Verkuil wrote: > > > More comments... > > > > > > On Friday 19 February 2010 20:21:59 Sakari Ailus wrote: > > >> Add support for event handling to do_ioctl. > > >>

Re: [PATCH v5 5/6] V4L: Events: Support event handling in do_ioctl

2010-02-21 Thread Hans Verkuil
On Sunday 21 February 2010 23:31:43 Sakari Ailus wrote: > Hans Verkuil wrote: > > More comments... > > > > On Friday 19 February 2010 20:21:59 Sakari Ailus wrote: > >> Add support for event handling to do_ioctl. > >> > >> Signed-off-by: Sakari Ailus > >> --- > >> drivers/media/video/v4l2-ioctl.c

Re: [PATCH v5 5/6] V4L: Events: Support event handling in do_ioctl

2010-02-21 Thread Sakari Ailus
Laurent Pinchart wrote: > Hi Sakari, Salut Laurent, >>> There is a crucial piece of functionality missing here: if the filehandle >>> is in blocking mode, then it should wait until an event arrives. That >>> also means that if vfh->events == NULL, you should still call >>> v4l2_event_dequeue, and

Re: [PATCH v5 5/6] V4L: Events: Support event handling in do_ioctl

2010-02-21 Thread Laurent Pinchart
Hi Sakari, On Sunday 21 February 2010 23:31:43 Sakari Ailus wrote: > Hans Verkuil wrote: > > More comments... > > > > On Friday 19 February 2010 20:21:59 Sakari Ailus wrote: > >> Add support for event handling to do_ioctl. > >> > >> Signed-off-by: Sakari Ailus > >> --- > >> > >> drivers/media

Re: [PATCH v5 5/6] V4L: Events: Support event handling in do_ioctl

2010-02-21 Thread Sakari Ailus
Hans Verkuil wrote: > More comments... > > On Friday 19 February 2010 20:21:59 Sakari Ailus wrote: >> Add support for event handling to do_ioctl. >> >> Signed-off-by: Sakari Ailus >> --- >> drivers/media/video/v4l2-ioctl.c | 58 >> ++ >> include/media/v4l2-

Re: [PATCH v5 5/6] V4L: Events: Support event handling in do_ioctl

2010-02-20 Thread Hans Verkuil
More comments... On Friday 19 February 2010 20:21:59 Sakari Ailus wrote: > Add support for event handling to do_ioctl. > > Signed-off-by: Sakari Ailus > --- > drivers/media/video/v4l2-ioctl.c | 58 > ++ > include/media/v4l2-ioctl.h |7 > 2 f

[PATCH v5 5/6] V4L: Events: Support event handling in do_ioctl

2010-02-19 Thread Sakari Ailus
Add support for event handling to do_ioctl. Signed-off-by: Sakari Ailus --- drivers/media/video/v4l2-ioctl.c | 58 ++ include/media/v4l2-ioctl.h |7 2 files changed, 65 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl