Re: [PATCH v5 8/9] vsp1: Fix lack of the sink entity registration for enabled links

2013-08-02 Thread Hans Verkuil


On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
 From: Katsuya Matsubara ma...@igel.co.jp
 
 Each source entity maintains a pointer to the counterpart sink
 entity while an enabled link connects them. It should be managed by
 the setup_link callback in the media controller framework at runtime.
 However, enabled links which connect RPFs and WPFs that have an
 equivalent index number are created during initialization.
 This registers the pointer to a sink entity from the source entity
 when an enabled link is created.
 
 Signed-off-by: Katsuya Matsubara ma...@igel.co.jp
 Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
 Acked-by: Sakari Ailus sakari.ai...@iki.fi

Acked-by: Hans Verkuil hans.verk...@cisco.com

Regards,

Hans
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v5 8/9] vsp1: Fix lack of the sink entity registration for enabled links

2013-08-01 Thread Laurent Pinchart
From: Katsuya Matsubara ma...@igel.co.jp

Each source entity maintains a pointer to the counterpart sink
entity while an enabled link connects them. It should be managed by
the setup_link callback in the media controller framework at runtime.
However, enabled links which connect RPFs and WPFs that have an
equivalent index number are created during initialization.
This registers the pointer to a sink entity from the source entity
when an enabled link is created.

Signed-off-by: Katsuya Matsubara ma...@igel.co.jp
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Acked-by: Sakari Ailus sakari.ai...@iki.fi
---
 drivers/media/platform/vsp1/vsp1_drv.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/media/platform/vsp1/vsp1_drv.c 
b/drivers/media/platform/vsp1/vsp1_drv.c
index e58e49c..41dd891 100644
--- a/drivers/media/platform/vsp1/vsp1_drv.c
+++ b/drivers/media/platform/vsp1/vsp1_drv.c
@@ -101,6 +101,9 @@ static int vsp1_create_links(struct vsp1_device *vsp1, 
struct vsp1_entity *sink)
   entity, pad, flags);
if (ret  0)
return ret;
+
+   if (flags  MEDIA_LNK_FL_ENABLED)
+   source-sink = entity;
}
}
 
-- 
1.8.1.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html