Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Laurent, One more comment-to-comment: On Mon, 7 May 2018, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday, 10 April 2018 14:31:35 EEST Guennadi Liakhovetski wrote: > > On Fri, 23 Mar 2018, Laurent Pinchart wrote: > > > On Friday, 23 March 2018 11:24:00 EET Laurent Pinchart wrote: > >

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Guennadi, On Monday, 7 May 2018 18:12:14 EEST Guennadi Liakhovetski wrote: > On Mon, 7 May 2018, Laurent Pinchart wrote: > > On Tuesday, 10 April 2018 14:31:35 EEST Guennadi Liakhovetski wrote: > >> On Fri, 23 Mar 2018, Laurent Pinchart wrote: > >>> On Friday, 23 March 2018 11:24:00 EET

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Laurent, Thanks for the replies. One follow-up question: On Mon, 7 May 2018, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday, 10 April 2018 14:31:35 EEST Guennadi Liakhovetski wrote: > > On Fri, 23 Mar 2018, Laurent Pinchart wrote: > > > On Friday, 23 March 2018 11:24:00 EET Laurent

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Guennadi, On Thursday, 26 April 2018 12:28:42 EEST Guennadi Liakhovetski wrote: > On Tue, 10 Apr 2018, Guennadi Liakhovetski wrote: > > [snip] > > >>> @@ -1488,6 +1591,25 @@ int uvc_ctrl_set(struct uvc_video_chain *chain, > >>> return -EINVAL; > >>> if (!(ctrl->info.flags &

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Guennadi, On Tuesday, 10 April 2018 14:31:35 EEST Guennadi Liakhovetski wrote: > On Fri, 23 Mar 2018, Laurent Pinchart wrote: > > On Friday, 23 March 2018 11:24:00 EET Laurent Pinchart wrote: > >> From: Guennadi Liakhovetski > >> > >> UVC defines a method of handling

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Laurent, On Tue, 10 Apr 2018, Guennadi Liakhovetski wrote: [snip] > > > @@ -1488,6 +1591,25 @@ int uvc_ctrl_set(struct uvc_video_chain *chain, > > > return -EINVAL; > > > if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) > > > return -EACCES; > > > + if (ctrl->info.flags

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Laurent, First a couple of replies to your questions. On Fri, 23 Mar 2018, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > On Friday, 23 March 2018 11:24:00 EET Laurent Pinchart wrote: > > From: Guennadi Liakhovetski > > > > UVC defines a

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Guennadi, On Saturday, 7 April 2018 12:30:44 EEST Guennadi Liakhovetski wrote: > Hi Laurent, > > Thanks for the review. As soon as the second patch has also been reviewed, > I'll work on both of them. I would have sworn I had sent the review for 2/2 as well. I'll get to it right away. > On

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Laurent, Thanks for the review. As soon as the second patch has also been reviewed, I'll work on both of them. Thanks Guennadi On Fri, 23 Mar 2018, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > On Friday, 23 March 2018 11:24:00 EET Laurent Pinchart wrote: > >

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Guennadi, Thank you for the patch. On Friday, 23 March 2018 11:24:00 EET Laurent Pinchart wrote: > From: Guennadi Liakhovetski > > UVC defines a method of handling asynchronous controls, which sends a > USB packet over the interrupt pipe. This patch implements support

[PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

From: Guennadi Liakhovetski UVC defines a method of handling asynchronous controls, which sends a USB packet over the interrupt pipe. This patch implements support for such packets by sending a control event to the user. Since this can involve USB traffic and, therefore,