Re: [PATCH v7 1/8] video: add display_timing struct and helpers

2012-11-04 Thread Steffen Trumtrar
On Thu, Nov 01, 2012 at 09:08:42PM +0100, Thierry Reding wrote: On Wed, Oct 31, 2012 at 10:28:01AM +0100, Steffen Trumtrar wrote: [...] +void timings_release(struct display_timings *disp) +{ + int i; + + for (i = 0; i disp-num_timings; i++) + kfree(disp-timings[i]);

Re: [PATCH v7 1/8] video: add display_timing struct and helpers

2012-11-01 Thread Thierry Reding
On Wed, Oct 31, 2012 at 10:28:01AM +0100, Steffen Trumtrar wrote: [...] +void timings_release(struct display_timings *disp) +{ + int i; + + for (i = 0; i disp-num_timings; i++) + kfree(disp-timings[i]); +} + +void display_timings_release(struct display_timings *disp)

[PATCH v7 1/8] video: add display_timing struct and helpers

2012-10-31 Thread Steffen Trumtrar
Add display_timing structure and the according helper functions. This allows the description of a display via its supported timing parameters. Every timing parameter can be specified as a single value or a range min typ max. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de ---

Re: [PATCH v7 1/8] video: add display_timing struct and helpers

2012-10-31 Thread Laurent Pinchart
Hi Steffen, Thanks for the patch. As we'll need a v8 anyway due to the comment on patch 5/8, here are a couple of other small comments. On Wednesday 31 October 2012 10:28:01 Steffen Trumtrar wrote: Add display_timing structure and the according helper functions. This allows the description

Re: [PATCH v7 1/8] video: add display_timing struct and helpers

2012-10-31 Thread Laurent Pinchart
Hi Steffen, One more comment. On Wednesday 31 October 2012 10:28:01 Steffen Trumtrar wrote: Add display_timing structure and the according helper functions. This allows the description of a display via its supported timing parameters. Every timing parameter can be specified as a single