Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-26 Thread Guennadi Liakhovetski
Hi Laurent, Thanks for the diff. I'm about to go over it and check your comments, but I cannot seem to find a git tree with your current stack. Particularly, you wanted to apply patches 1 and 3 from this series before applying this one, so, I'd prefer to work on top of the same tree as you to

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-25 Thread Laurent Pinchart
Hi Guennadi, On Wednesday, 25 July 2018 20:21:54 EEST Guennadi Liakhovetski wrote: > On Wed, 25 Jul 2018, Laurent Pinchart wrote: > > On Wednesday, 18 July 2018 09:55:27 EEST Guennadi Liakhovetski wrote: > >> On Wed, 18 Jul 2018, Laurent Pinchart wrote: > >>> On Wednesday, 18 July 2018 00:30:45

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-25 Thread Laurent Pinchart
Hi Guennadi, On Wednesday, 25 July 2018 20:25:16 EEST Laurent Pinchart wrote: > On Tuesday, 8 May 2018 18:07:43 EEST Guennadi Liakhovetski wrote: > > UVC defines a method of handling asynchronous controls, which sends a > > USB packet over the interrupt pipe. This patch implements support for > >

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-25 Thread Laurent Pinchart
Hi Guennadi, On Tuesday, 8 May 2018 18:07:43 EEST Guennadi Liakhovetski wrote: > UVC defines a method of handling asynchronous controls, which sends a > USB packet over the interrupt pipe. This patch implements support for > such packets by sending a control event to the user. Since this can >

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-25 Thread Guennadi Liakhovetski
On Wed, 25 Jul 2018, Laurent Pinchart wrote: > Hi Guennadi, > > On Wednesday, 18 July 2018 09:55:27 EEST Guennadi Liakhovetski wrote: > > On Wed, 18 Jul 2018, Laurent Pinchart wrote: > > > On Wednesday, 18 July 2018 00:30:45 EEST Guennadi Liakhovetski wrote: > > >> On Tue, 17 Jul 2018, Laurent

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-25 Thread Laurent Pinchart
Hi Guennadi, On Wednesday, 18 July 2018 09:55:27 EEST Guennadi Liakhovetski wrote: > On Wed, 18 Jul 2018, Laurent Pinchart wrote: > > On Wednesday, 18 July 2018 00:30:45 EEST Guennadi Liakhovetski wrote: > >> On Tue, 17 Jul 2018, Laurent Pinchart wrote: > >>> On Thursday, 12 July 2018 10:30:46

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-18 Thread Guennadi Liakhovetski
Hi Laurent, On Wed, 18 Jul 2018, Laurent Pinchart wrote: > Hi Guennadi, > > On Wednesday, 18 July 2018 00:30:45 EEST Guennadi Liakhovetski wrote: > > On Tue, 17 Jul 2018, Laurent Pinchart wrote: > > > On Thursday, 12 July 2018 10:30:46 EEST Guennadi Liakhovetski wrote: > > >> On Thu, 12 Jul

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-17 Thread Laurent Pinchart
Hi Guennadi, On Wednesday, 18 July 2018 00:30:45 EEST Guennadi Liakhovetski wrote: > On Tue, 17 Jul 2018, Laurent Pinchart wrote: > > On Thursday, 12 July 2018 10:30:46 EEST Guennadi Liakhovetski wrote: > >> On Thu, 12 Jul 2018, Laurent Pinchart wrote: > >>> On Tuesday, 8 May 2018 18:07:43 EEST

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-17 Thread Guennadi Liakhovetski
On Tue, 17 Jul 2018, Laurent Pinchart wrote: > Hi Guennadi, > > On Thursday, 12 July 2018 10:30:46 EEST Guennadi Liakhovetski wrote: > > On Thu, 12 Jul 2018, Laurent Pinchart wrote: > > > On Tuesday, 8 May 2018 18:07:43 EEST Guennadi Liakhovetski wrote: > > >> UVC defines a method of handling

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-17 Thread Laurent Pinchart
Hi Guennadi, On Thursday, 12 July 2018 10:30:46 EEST Guennadi Liakhovetski wrote: > On Thu, 12 Jul 2018, Laurent Pinchart wrote: > > On Tuesday, 8 May 2018 18:07:43 EEST Guennadi Liakhovetski wrote: > >> UVC defines a method of handling asynchronous controls, which sends a > >> USB packet over

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-17 Thread Guennadi Liakhovetski
Hi Laurent, On Thu, 12 Jul 2018, Guennadi Liakhovetski wrote: > Hi Laurent, > > Thanks for the review. [snip] > Once I get your review of patch #3, I'll fix these two issues and > resubmit, so you can also tell me your "minor concerns," since I'll be > resubmitting anyway. Any progress on

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-12 Thread Guennadi Liakhovetski
Hi Laurent, Thanks for the review. On Thu, 12 Jul 2018, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > On Tuesday, 8 May 2018 18:07:43 EEST Guennadi Liakhovetski wrote: > > UVC defines a method of handling asynchronous controls, which sends a > > USB packet over the

Re: [PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-07-11 Thread Laurent Pinchart
Hi Guennadi, Thank you for the patch. On Tuesday, 8 May 2018 18:07:43 EEST Guennadi Liakhovetski wrote: > UVC defines a method of handling asynchronous controls, which sends a > USB packet over the interrupt pipe. This patch implements support for > such packets by sending a control event to the

[PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2018-05-08 Thread Guennadi Liakhovetski
UVC defines a method of handling asynchronous controls, which sends a USB packet over the interrupt pipe. This patch implements support for such packets by sending a control event to the user. Since this can involve USB traffic and, therefore, scheduling, this has to be done in a work queue.