Re: [PATCH v9 2/2] video: drm: exynos: Add pinctrl support to fimd

2013-03-01 Thread Vikas Sajjan
Hi Linus, On Fri, Mar 1, 2013 at 2:49 PM, Linus Walleij wrote: > On Thu, Feb 28, 2013 at 5:12 AM, Vikas Sajjan wrote: > >> Adds support for pinctrl to drm fimd >> >> Signed-off-by: Leela Krishna Amudala >> Signed-off-by: Vikas Sajjan > (...) >> + pctrl = devm_pinctrl_get_select_d

Re: [PATCH v9 2/2] video: drm: exynos: Add pinctrl support to fimd

2013-03-01 Thread Linus Walleij
On Thu, Feb 28, 2013 at 5:12 AM, Vikas Sajjan wrote: > Adds support for pinctrl to drm fimd > > Signed-off-by: Leela Krishna Amudala > Signed-off-by: Vikas Sajjan (...) > + pctrl = devm_pinctrl_get_select_default(dev); NAK. The device core will do this for you as of commit ab780

Re: [PATCH v9 2/2] video: drm: exynos: Add pinctrl support to fimd

2013-02-28 Thread Russell King - ARM Linux
On Thu, Feb 28, 2013 at 11:03:57PM +0100, Sylwester Nawrocki wrote: > Please just use IS_ERR(), let's stop this IS_ERR_OR_NULL() insanity. Yes, indeed. On that topic (and off-topic for this thread, sorry) I've committed a set of patches to remove most users of IS_ERR_OR_NULL() from arch/arm. Thes

Re: [PATCH v9 2/2] video: drm: exynos: Add pinctrl support to fimd

2013-02-28 Thread Sylwester Nawrocki
On 02/28/2013 05:12 AM, Vikas Sajjan wrote: Adds support for pinctrl to drm fimd Signed-off-by: Leela Krishna Amudala Signed-off-by: Vikas Sajjan --- drivers/gpu/drm/exynos/exynos_drm_fimd.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd

[PATCH v9 2/2] video: drm: exynos: Add pinctrl support to fimd

2013-02-27 Thread Vikas Sajjan
Adds support for pinctrl to drm fimd Signed-off-by: Leela Krishna Amudala Signed-off-by: Vikas Sajjan --- drivers/gpu/drm/exynos/exynos_drm_fimd.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c