From: Hans Verkuil <hans.verk...@cisco.com>

Prevent out-of-range register accesses.

Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
---
 drivers/media/pci/saa7146/mxb.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/media/pci/saa7146/mxb.c b/drivers/media/pci/saa7146/mxb.c
index 8d17769..33abe33 100644
--- a/drivers/media/pci/saa7146/mxb.c
+++ b/drivers/media/pci/saa7146/mxb.c
@@ -669,6 +669,8 @@ static int vidioc_g_register(struct file *file, void *fh, 
struct v4l2_dbg_regist
 {
        struct saa7146_dev *dev = ((struct saa7146_fh *)fh)->dev;
 
+       if (reg->reg > pci_resource_len(dev->pci, 0) - 4)
+               return -EINVAL;
        reg->val = saa7146_read(dev, reg->reg);
        reg->size = 4;
        return 0;
@@ -678,6 +680,8 @@ static int vidioc_s_register(struct file *file, void *fh, 
const struct v4l2_dbg_
 {
        struct saa7146_dev *dev = ((struct saa7146_fh *)fh)->dev;
 
+       if (reg->reg > pci_resource_len(dev->pci, 0) - 4)
+               return -EINVAL;
        saa7146_write(dev, reg->reg, reg->val);
        return 0;
 }
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to