On Thu, 2011-07-28 at 16:34 +0200, Laurent Pinchart wrote:
- adp1653_init_controls(flash);
+ ret = adp1653_init_controls(flash);
+ if (ret)
+ goto free_and_quit;
ret = media_entity_init(flash-subdev.entity, 0, NULL, 0);
if (ret 0)
-
Potentially the adp1653_init_controls could return an error. In our case the
error was ignored, meanwhile it means incorrect initialization of V4L2
controls. Additionally we have to free control handler structures in case of
apd1653_init_controls or media_entity_init failure.
Signed-off-by: Andy
Hi Andy,
On Thursday 28 July 2011 09:59:38 Andy Shevchenko wrote:
Potentially the adp1653_init_controls could return an error. In our case
the error was ignored, meanwhile it means incorrect initialization of V4L2
controls. Additionally we have to free control handler structures in case
of