Re: [PATCHv2 00/94] Only use DVBv5 internally on frontend drivers
On 01/01/2012 09:12 PM, Mauro Carvalho Chehab wrote: > On 01-01-2012 13:23, Sylwester Nawrocki wrote: >> On 12/30/2011 05:45 PM, Mauro Carvalho Chehab wrote: >>> On 30-12-2011 14:36, Sylwester Nawrocki wrote: On 12/30/2011 04:06 PM, Mauro Carvalho Chehab wrote: > This patch series comes after the previous series of 47 patches. > Basically, changes all DVB frontend drivers to work directly with > the DVBv5 structure. This warrants that all drivers will be Is there any git tree available with all these patches ? It would be easier to pull rather than applying almost 150 patches. :) I know I don't need them all, but just to be sure I have all the relevant changes in place for testing. >>> >>> Forgot to mention, and to update them on my tree. The latest version are at >>> the branch "DVB_v5_v5" on my experimental tree: >>> >>> http://git.linuxtv.org/mchehab/experimental.git/shortlog/refs/heads/DVB_v5_v5 >>> >>> (yeah, I know: the name become weird... It were "DVB_v5", meaning DVB API >>> v5, >>> then, for each rebase, I added a new branch there) >> >> Just for the record, I've tested it with as102 driver (pctv74e usb stick) and >> MeTV and didn't notice any runtime problems. > > Thank you for testing it, Sylvester! > > I wrote yet another set of patches (this is a shorter one) meant to finish > the DVB cleanup. > > The new series addresses some issues inside dvb_frontend.c. It is at: > > git://linuxtv.org/mchehab/experimental.git DVBv5-v7 I've tested this one in same way and didn't find any regressions. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 00/94] Only use DVBv5 internally on frontend drivers
On 01-01-2012 13:23, Sylwester Nawrocki wrote: > On 12/30/2011 05:45 PM, Mauro Carvalho Chehab wrote: >> On 30-12-2011 14:36, Sylwester Nawrocki wrote: >>> Hi Mauro, >>> >>> On 12/30/2011 04:06 PM, Mauro Carvalho Chehab wrote: This patch series comes after the previous series of 47 patches. Basically, changes all DVB frontend drivers to work directly with the DVBv5 structure. This warrants that all drivers will be >>> >>> Is there any git tree available with all these patches ? It would be easier >>> to pull rather than applying almost 150 patches. :) I know I don't need >>> them all, but just to be sure I have all the relevant changes in place for >>> testing. >> >> Forgot to mention, and to update them on my tree. The latest version are at >> the branch "DVB_v5_v5" on my experimental tree: >> >> http://git.linuxtv.org/mchehab/experimental.git/shortlog/refs/heads/DVB_v5_v5 >> >> (yeah, I know: the name become weird... It were "DVB_v5", meaning DVB API v5, >> then, for each rebase, I added a new branch there) > > Just for the record, I've tested it with as102 driver (pctv74e usb stick) and > MeTV and didn't notice any runtime problems. Thank you for testing it, Sylvester! I wrote yet another set of patches (this is a shorter one) meant to finish the DVB cleanup. The new series addresses some issues inside dvb_frontend.c. It is at: git://linuxtv.org/mchehab/experimental.git DVBv5-v7 Thanks! Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 00/94] Only use DVBv5 internally on frontend drivers
On 12/30/2011 05:45 PM, Mauro Carvalho Chehab wrote: > On 30-12-2011 14:36, Sylwester Nawrocki wrote: >> Hi Mauro, >> >> On 12/30/2011 04:06 PM, Mauro Carvalho Chehab wrote: >>> This patch series comes after the previous series of 47 patches. >>> Basically, changes all DVB frontend drivers to work directly with >>> the DVBv5 structure. This warrants that all drivers will be >> >> Is there any git tree available with all these patches ? It would be easier >> to pull rather than applying almost 150 patches. :) I know I don't need >> them all, but just to be sure I have all the relevant changes in place for >> testing. > > Forgot to mention, and to update them on my tree. The latest version are at > the branch "DVB_v5_v5" on my experimental tree: > > http://git.linuxtv.org/mchehab/experimental.git/shortlog/refs/heads/DVB_v5_v5 > > (yeah, I know: the name become weird... It were "DVB_v5", meaning DVB API v5, > then, for each rebase, I added a new branch there) Just for the record, I've tested it with as102 driver (pctv74e usb stick) and MeTV and didn't notice any runtime problems. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 00/94] Only use DVBv5 internally on frontend drivers
On 31-12-2011 13:31, Stefan Richter wrote: > On Dec 30 Mauro Carvalho Chehab wrote: >> Basically, changes all DVB frontend drivers to work directly with >> the DVBv5 structure. > [...] >> Test reports are welcome. > [...] >> [media] firedtv: convert set_fontend to use DVBv5 parameters > [...] >> drivers/media/dvb/firewire/firedtv-avc.c | 95 >> drivers/media/dvb/firewire/firedtv-fe.c | 31 ++ >> drivers/media/dvb/firewire/firedtv.h |4 +- > > I briefly tested git://linuxtv.org/media_tree.gitstaging/for_v3.3 > 7c61d80a9bcf on top of v3.2-rc7 on a FireDTV-T/CI with kaffeine and on a > FireDTV-C/CI with kaffeine and smplayer and didn't notice any runtime problem. Thanks for testing it! > Building fs/compat_ioctl.c failed for me though: > fs/compat_ioctl.c:1345:1: error: invalid application of ‘sizeof’ to > incomplete type ‘struct dvb_frontend_parameters’ > fs/compat_ioctl.c:1345:1: error: array type has incomplete element type > etc. pp. Yeah, I forgot about the compat stuff ;) The fix is simple: http://git.linuxtv.org/media_tree.git/commit/e97a5d893fdf45c20799b72a1c11dca3b282c89c Basically, one patch at the tree avoids the usage of DVBv3 structs inside the drivers, as this is not supported by the DVB core anymore. The core itself (and compat) will need it, in order to provide DVBv3 compatibility. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 00/94] Only use DVBv5 internally on frontend drivers
On Dec 30 Mauro Carvalho Chehab wrote: > Basically, changes all DVB frontend drivers to work directly with > the DVBv5 structure. [...] > Test reports are welcome. [...] > [media] firedtv: convert set_fontend to use DVBv5 parameters [...] > drivers/media/dvb/firewire/firedtv-avc.c | 95 > drivers/media/dvb/firewire/firedtv-fe.c | 31 ++ > drivers/media/dvb/firewire/firedtv.h |4 +- I briefly tested git://linuxtv.org/media_tree.gitstaging/for_v3.3 7c61d80a9bcf on top of v3.2-rc7 on a FireDTV-T/CI with kaffeine and on a FireDTV-C/CI with kaffeine and smplayer and didn't notice any runtime problem. Building fs/compat_ioctl.c failed for me though: fs/compat_ioctl.c:1345:1: error: invalid application of ‘sizeof’ to incomplete type ‘struct dvb_frontend_parameters’ fs/compat_ioctl.c:1345:1: error: array type has incomplete element type etc. pp. -- Stefan Richter -=-==-== ==-- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 00/94] Only use DVBv5 internally on frontend drivers
On 30-12-2011 14:36, Sylwester Nawrocki wrote: > Hi Mauro, > > On 12/30/2011 04:06 PM, Mauro Carvalho Chehab wrote: >> This patch series comes after the previous series of 47 patches. >> Basically, changes all DVB frontend drivers to work directly with >> the DVBv5 structure. This warrants that all drivers will be > > Is there any git tree available with all these patches ? It would be easier > to pull rather than applying almost 150 patches. :) I know I don't need > them all, but just to be sure I have all the relevant changes in place for > testing. Forgot to mention, and to update them on my tree. The latest version are at the branch "DVB_v5_v5" on my experimental tree: http://git.linuxtv.org/mchehab/experimental.git/shortlog/refs/heads/DVB_v5_v5 (yeah, I know: the name become weird... It were "DVB_v5", meaning DVB API v5, then, for each rebase, I added a new branch there) > > -- > Thanks, > Sylwester > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 00/94] Only use DVBv5 internally on frontend drivers
Hi Mauro, On 12/30/2011 04:06 PM, Mauro Carvalho Chehab wrote: > This patch series comes after the previous series of 47 patches. > Basically, changes all DVB frontend drivers to work directly with > the DVBv5 structure. This warrants that all drivers will be Is there any git tree available with all these patches ? It would be easier to pull rather than applying almost 150 patches. :) I know I don't need them all, but just to be sure I have all the relevant changes in place for testing. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCHv2 00/94] Only use DVBv5 internally on frontend drivers
This patch series comes after the previous series of 47 patches. Basically, changes all DVB frontend drivers to work directly with the DVBv5 structure. This warrants that all drivers will be getting/setting frontend parameters on a consistent way, and opens space for improving the DVB core, in order to avoid copying data from/to the DVBv3 structs without need. Most of the patches on this series are trivial changes. Yet, it would be great to test them, in order to be sure that nothing broke. The last patch in this series hide the DVBv3 parameters struct from the frontend drivers, keeping them visible only to the dvb_core. This helps to warrant that everything were ported, and that newer patches won't re-introduce DVBv3 structs by mistake. There aren't many cleanups inside the dvb_frontend.c yet. Before cleaning up the core, I intend to do some tests with a some devices, in order to be sure that nothing broke with all those changes. Test reports are welcome. --- version 2: - Improve descriptions of patches 1, 3 and 24, based on the Andreas feedback; - Added 3 patches to the series: 3e737d9 [media] s921: Properly report the delivery system Trivial fix. Without this one, the driver return SYS_UNDEFINED to a get_frontend() call. 9d0bb55 dvb_frontend: Fix inversion breakage due to DVBv5 conversion Fixes inversion handling. The current code doesn't update the DVBv5 inside some tuning logic (frequency drifts aren't updated, nor inversion logic). c89c2e7 [media] dvb: don't require a parameter for get_frontend Just like set_frontend(), uses the DVBv5 cache for get fops. Mauro Carvalho Chehab (94): [media] dvb-core: allow demods to specify the supported delsys [media] Rename set_frontend fops to set_frontend_legacy [media] dvb-core: add support for a DVBv5 get_frontend() callback [media] af9013: convert set_fontend to use DVBv5 parameters [media] atbm8830: convert set_fontend to new way and fix delivery system [media] au8522_dig: convert set_fontend to use DVBv5 parameters [media] bcm3510: convert set_fontend to use DVBv5 parameters [media] cx22700: convert set_fontend to use DVBv5 parameters [media] cx22702: convert set_fontend to use DVBv5 parameters [media] cx24110: convert set_fontend to use DVBv5 parameters [media] cx24116: report delivery system and cleanups [media] cx23123: remove an unused argument from cx24123_pll_writereg() [media] av7110: convert set_fontend to use DVBv5 parameters [media] cx23123: convert set_fontend to use DVBv5 parameters [media] cxd2820r: report delivery system and cleanups [media] dibx000: convert set_fontend to use DVBv5 parameters [media] dib9000: remove unused parameters [media] cx24113: cleanup: remove unused init [media] dib9000: Get rid of the remaining DVBv3 legacy stuff [media] dib3000mb: convert set_fontend to use DVBv5 parameters [media] dib8000: Remove the old DVBv3 struct from it and add delsys [media] dib9000: get rid of unused dvb_frontend_parameters [media] zl10353: convert set_fontend to use DVBv5 parameters [media] em28xx-dvb: don't initialize drx-d non-used fields with zero [media] drxd: convert set_fontend to use DVBv5 parameters [media] drxk: convert set_fontend to use DVBv5 parameters [media] ds3000: convert set_fontend to use DVBv5 parameters [media] dvb_dummy_fe: convert set_fontend to use DVBv5 parameters [media] ec100: convert set_fontend to use DVBv5 parameters [media] it913x-fe: convert set_fontend to use DVBv5 parameters [media] l64781: convert set_fontend to use DVBv5 parameters [media] lgs8gl5: convert set_fontend to use DVBv5 parameters [media] lgdt330x: convert set_fontend to use DVBv5 parameters [media] lgdt3305: convert set_fontend to use DVBv5 parameters [media] lgs8gxx: convert set_fontend to use DVBv5 parameters [media] vez1x93: convert set_fontend to use DVBv5 parameters [media] mb86a16: Add delivery system type at fe struct [media] mb86a20s: convert set_fontend to use DVBv5 parameters [media] mt352: convert set_fontend to use DVBv5 parameters [media] nxt6000: convert set_fontend to use DVBv5 parameters [media] s5h1432: convert set_fontend to use DVBv5 parameters [media] sp8870: convert set_fontend to use DVBv5 parameters [media] sp887x: convert set_fontend to use DVBv5 parameters [media] stv0367: convert set_fontend to use DVBv5 parameters [media] tda10048: convert set_fontend to use DVBv5 parameters [media] tda1004x: convert set_fontend to use DVBv5 parameters [media] s921: convert set_fontend to use DVBv5 parameters [media] mt312: convert set_fontend to use DVBv5 parameters [media] s5h1420: convert set_fontend to use DVBv5 parameters [media] si21xx: convert set_fontend to use DVBv5 parameters [media] stb0899: convert get_frontend to the new struct [media] stb6100: use get_frontend, instead of get_frontend_legacy() [media] stv0288: convert set_fontend to use DVBv5 parameters
