Re: [PATCHv3 2/4] v4l: vsp1: Refactor video pipeline configuration

2017-01-06 Thread Kieran Bingham
Hi Laurent, I've been reworking this series to split things out and adapt for the comments you've provided, but I have the following queries outstanding: On 15/12/16 11:50, Kieran Bingham wrote: > Hi Laurent, > > On 14/12/16 16:30, Laurent Pinchart wrote: >> Hi Kieran, >> >> Thank you for the

Re: [PATCHv3 2/4] v4l: vsp1: Refactor video pipeline configuration

2016-12-15 Thread Kieran Bingham
Hi Laurent, On 14/12/16 16:30, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday 13 Dec 2016 17:59:42 Kieran Bingham wrote: >> With multiple inputs through the BRU it is feasible for the streams to >> race each other at stream-on. > > Could you please explain the

Re: [PATCHv3 2/4] v4l: vsp1: Refactor video pipeline configuration

2016-12-14 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday 13 Dec 2016 17:59:42 Kieran Bingham wrote: > With multiple inputs through the BRU it is feasible for the streams to > race each other at stream-on. Could you please explain the race condition in the commit message ? The issue is that multiple

[PATCHv3 2/4] v4l: vsp1: Refactor video pipeline configuration

2016-12-13 Thread Kieran Bingham
With multiple inputs through the BRU it is feasible for the streams to race each other at stream-on. In the case of the video pipelines, this can present two serious issues. 1) A null-dereference if the pipe->dl is committed at the same time as the vsp1_video_setup_pipeline() is processing