Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-05-19 Thread Patrick Boettcher
On Tue, 19 May 2015 12:25:19 +0100 Jemma Denson wrote: > On 19/05/15 11:57, Mauro Carvalho Chehab wrote: > > > >> The only thing left now is moving UCB & BER over to DVBv5 stats - we > >> haven't got anything close to any specs for this demod so I'm struggling > >> to work out how to handle the c

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-05-19 Thread Jemma Denson
On 19/05/15 11:57, Mauro Carvalho Chehab wrote: The only thing left now is moving UCB & BER over to DVBv5 stats - we haven't got anything close to any specs for this demod so I'm struggling to work out how to handle the counter increment. It's not helped by my signal not being marginal enough t

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-05-19 Thread Mauro Carvalho Chehab
Em Fri, 15 May 2015 16:18:07 +0100 Jemma Denson escreveu: > Hi Mauro, > > On 15/05/15 15:24, Mauro Carvalho Chehab wrote: > >> Of course. Jemma and me (mainly Jemma) are progressing and might be > >> able to resubmit everything this weekend. > > Good! Thanks for the good work! > > > > Mauro > >

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-05-15 Thread Jemma Denson
Hi Mauro, On 15/05/15 15:24, Mauro Carvalho Chehab wrote: Of course. Jemma and me (mainly Jemma) are progressing and might be able to resubmit everything this weekend. Good! Thanks for the good work! Mauro The only thing left now is moving UCB & BER over to DVBv5 stats - we haven't got any

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-05-15 Thread Mauro Carvalho Chehab
Em Fri, 15 May 2015 10:24:33 +0200 Patrick Boettcher escreveu: > Hi Mauro, > > On Thu, 14 May 2015 18:40:40 -0300 Mauro Carvalho Chehab > wrote: > > > Em Wed, 29 Apr 2015 08:55:26 -0300 > > Mauro Carvalho Chehab escreveu: > > > > > Em Wed, 29 Apr 2015 13:35:01 +0200 > > > Patrick Boettcher

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-05-15 Thread Patrick Boettcher
Hi Mauro, On Thu, 14 May 2015 18:40:40 -0300 Mauro Carvalho Chehab wrote: > Em Wed, 29 Apr 2015 08:55:26 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Wed, 29 Apr 2015 13:35:01 +0200 > > Patrick Boettcher escreveu: > > > > > Hi Mauro, > > > > > > On Mon, 27 Apr 2015 21:40:22 -0300 Mauro

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-05-14 Thread Mauro Carvalho Chehab
Em Wed, 29 Apr 2015 08:55:26 -0300 Mauro Carvalho Chehab escreveu: > Em Wed, 29 Apr 2015 13:35:01 +0200 > Patrick Boettcher escreveu: > > > Hi Mauro, > > > > On Mon, 27 Apr 2015 21:40:22 -0300 Mauro Carvalho Chehab > > wrote: > > > > Could we send an additional patch for coding-style or would

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-04-29 Thread Mauro Carvalho Chehab
Em Wed, 29 Apr 2015 13:35:01 +0200 Patrick Boettcher escreveu: > Hi Mauro, > > On Mon, 27 Apr 2015 21:40:22 -0300 Mauro Carvalho Chehab > wrote: > > > Could we send an additional patch for coding-style or would you prefer > > > a new patch which has everything inside? This would maintain the >

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-04-29 Thread Patrick Boettcher
Hi Mauro, On Mon, 27 Apr 2015 21:40:22 -0300 Mauro Carvalho Chehab wrote: > > Could we send an additional patch for coding-style or would you prefer > > a new patch which has everything inside? This would maintain the > > author-attribution of the initial commit. > > An additional patch is fine.

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-04-27 Thread Mauro Carvalho Chehab
Em Mon, 27 Apr 2015 23:25:23 +0200 Patrick Boettcher escreveu: > Thank you for your review Mauro. > > In total there are about 3-4 (it's a guess) users of this driver and > this, written-once read-never, code is for a hardware which is very > unlikely to be ever reused again ever. Sometimes I re

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-04-27 Thread Jemma Denson
(Resending to fix reply-all) Hi Mauro, Thanks for taking the time to look into this. I'll let Patrick respond to the first part regards the pull request - I'll just respond to the points you've made about the driver itself. On 27/04/15 21:16, Mauro Carvalho Chehab wrote: > + > + > +/* Write

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-04-27 Thread Patrick Boettcher
Thank you for your review Mauro. In total there are about 3-4 (it's a guess) users of this driver and this, written-once read-never, code is for a hardware which is very unlikely to be ever reused again ever. Sometimes I regret that there is no carpet in OpenSource where you could hide the dirt un

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-04-27 Thread Mauro Carvalho Chehab
Em Mon, 20 Apr 2015 09:27:20 +0200 Patrick Boettcher escreveu: > Hi Mauro, > > Would you please pull the following two patches for finally > mainlining the Technisat SkyStar S2 (and its frontend cx24120). > > Ideally for 4.1, but I assume it is too late. So for 4.2. Hi Patrick, It was too lat

[PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-04-20 Thread Patrick Boettcher
Hi Mauro, Would you please pull the following two patches for finally mainlining the Technisat SkyStar S2 (and its frontend cx24120). Ideally for 4.1, but I assume it is too late. So for 4.2. Please also tell whether a pull-request is OK for you or whether you prefer patches. I'm based on the c