Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Abylai Ospan wrote: On Sat, 2010-01-16 at 11:18 -0200, Mauro Carvalho Chehab wrote: Abylai Ospan wrote: Mauro, Please pulll change: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/fc3e44f30da3 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. 22kHz logic controlled by demod. This patch modified after discussion with Oliver. This version is acceptable for both side ... Thanks. Your site seems to be down: abort: error: No route to host Please send me a pull request when the site returns. Please try again. Should work. Thanks. You forgot to sign it. You can simply reply to this email with your SOB, as I'll need to add Olvier's ack on it also. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hello, On Fri, 2010-01-22 at 15:34 -0200, Mauro Carvalho Chehab wrote: You forgot to sign it. You can simply reply to this email with your SOB, as I'll need to add Olvier's ack on it also. fixed. http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/058d68daed91 -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Abylai Ospan wrote: Hello, On Fri, 2010-01-22 at 15:34 -0200, Mauro Carvalho Chehab wrote: You forgot to sign it. You can simply reply to this email with your SOB, as I'll need to add Olvier's ack on it also. fixed. http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/058d68daed91 Applied on -git, thanks. PS.: Douglas should update -hg tree when he have time. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
On Fri, 2010-01-22 at 17:31 -0200, Mauro Carvalho Chehab wrote: Abylai Ospan wrote: Hello, On Fri, 2010-01-22 at 15:34 -0200, Mauro Carvalho Chehab wrote: You forgot to sign it. You can simply reply to this email with your SOB, as I'll need to add Olvier's ack on it also. fixed. http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/058d68daed91 Applied on -git, thanks. PS.: Douglas should update -hg tree when he have time. ok, thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hello, On Fri, Jan 22, 2010 at 5:31 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Abylai Ospan wrote: Hello, On Fri, 2010-01-22 at 15:34 -0200, Mauro Carvalho Chehab wrote: You forgot to sign it. You can simply reply to this email with your SOB, as I'll need to add Olvier's ack on it also. fixed. http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/058d68daed91 Applied on -git, thanks. PS.: Douglas should update -hg tree when he have time. Applied on -hg tree, thanks Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Abylai Ospan wrote: On Sat, 2010-01-16 at 11:18 -0200, Mauro Carvalho Chehab wrote: Abylai Ospan wrote: Mauro, Please pulll change: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/fc3e44f30da3 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. 22kHz logic controlled by demod. This patch modified after discussion with Oliver. This version is acceptable for both side ... Thanks. Your site seems to be down: abort: error: No route to host Please send me a pull request when the site returns. Please try again. Should work. Thanks. Patch is ok. Signed-off-by: Oliver Endriss o.endr...@gmx.de Oliver -- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ 4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/ Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Abylai Ospan wrote: Mauro, Please pulll change: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/fc3e44f30da3 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. 22kHz logic controlled by demod. This patch modified after discussion with Oliver. This version is acceptable for both side ... Thanks. Your site seems to be down: abort: error: No route to host Please send me a pull request when the site returns. Cheers, Mauro. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
On Sat, 2010-01-16 at 11:18 -0200, Mauro Carvalho Chehab wrote: Abylai Ospan wrote: Mauro, Please pulll change: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/fc3e44f30da3 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. 22kHz logic controlled by demod. This patch modified after discussion with Oliver. This version is acceptable for both side ... Thanks. Your site seems to be down: abort: error: No route to host Please send me a pull request when the site returns. Please try again. Should work. Thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hello Oliver, There is no reason why we have to use the set_tone routine of the stv0900. You can combine - set_tone of LNBH24 with - stv090x_send_diseqc_msg of stv0900 without losing anything. Before a DiSEqC message will be sent, the tone will be disabled. Then the stv090x_send_diseqc_msg of the stv0900 can control the 22kHz tone generator of the LNBH24 using EXTM or DSQIN. yes, you right. I think lnbp21_set_tone will be used if set_tone is not defined previously (set_tone == NULL). Is this correct ? No, sorry. set_tone had to be added, because the stv0900 can also operate in DiSEqC envelope mode (connected to DSQIN of the LNBH24). In this mode set_tone of the LNBH24 has to be used. ok, you right. But seems like fe-ops.set_tone = lnbp21_set_tone; override .set_tone = stv090x_set_tone, and stv090x_set_tone never used. Is this right ? Also please check our logic. We set override_clear=LNBH24_TEN in cx23885-dvb.c i.e. we disabling 22kHz logic in LNBH24 and all 22kHz logic driven from one place ( stv0900 ). This more clear for debugging (hardware and software ). This problem is reported by one of our customer. Your changeset 13673:75331e740f61 is broke 22khz tone functionality on our cards. We need to find compromise. Reverting the patch is not a problem ( in this case we need to remove override_clear=LNBH24_TEN). -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hi, Abylai Ospan wrote: Hello Oliver, There is no reason why we have to use the set_tone routine of the stv0900. You can combine - set_tone of LNBH24 with - stv090x_send_diseqc_msg of stv0900 without losing anything. Before a DiSEqC message will be sent, the tone will be disabled. Then the stv090x_send_diseqc_msg of the stv0900 can control the 22kHz tone generator of the LNBH24 using EXTM or DSQIN. yes, you right. I think lnbp21_set_tone will be used if set_tone is not defined previously (set_tone == NULL). Is this correct ? No, sorry. set_tone had to be added, because the stv0900 can also operate in DiSEqC envelope mode (connected to DSQIN of the LNBH24). In this mode set_tone of the LNBH24 has to be used. ok, you right. But seems like fe-ops.set_tone = lnbp21_set_tone; override .set_tone = stv090x_set_tone, and stv090x_set_tone never used. Is this right ? Correct. Also please check our logic. We set override_clear=LNBH24_TEN in cx23885-dvb.c i.e. we disabling 22kHz logic in LNBH24 and all 22kHz logic driven from one place ( stv0900 ). Well, if you specify override_clear=LNBH24_TEN then we have a problem. Possible solutions: a) Do not set LNBH24_TEN in override_clear, or b) Modify your patch to something like that: if (!(override_clear LNBH24_TEN)) fe-ops.set_tone = lnbp21_set_tone; Both will fix the issue. This more clear for debugging (hardware and software ). This problem is reported by one of our customer. Your changeset 13673:75331e740f61 is broke 22khz tone functionality on our cards. Ok, I did not expect that someone would set LNBH24_TEN in override_clear. ;-) We need to find compromise. Reverting the patch is not a problem ( in this case we need to remove override_clear=LNBH24_TEN). No problem. Both solutions above are ok for me. Maybe b) is more robust, because it allows override_clear=LNBH24_TEN to be used. I leaveit to you: Choose the one you like. Regards, Oliver -- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ 4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/ Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Mauro, Please pulll change: http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/fc3e44f30da3 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. 22kHz logic controlled by demod. This patch modified after discussion with Oliver. This version is acceptable for both side ... Thanks. -- Abylai Ospan aos...@netup.ru NetUP Inc. signature.asc Description: This is a digitally signed message part
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hello, On Thu, 2010-01-14 at 14:44 +0100, Oliver Endriss wrote: This more clear for debugging (hardware and software ). This problem is reported by one of our customer. Your changeset 13673:75331e740f61 is broke 22khz tone functionality on our cards. Ok, I did not expect that someone would set LNBH24_TEN in override_clear. ;-) yes, this not trivial to trace all override definitions :) We need to find compromise. Reverting the patch is not a problem ( in this case we need to remove override_clear=LNBH24_TEN). No problem. Both solutions above are ok for me. Maybe b) is more robust, because it allows override_clear=LNBH24_TEN to be used. I leaveit to you: Choose the one you like. ok. second is choosen - it's no broke yours and our logic. -- Abylai Ospan aos...@netup.ru NetUP Inc. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Mauro, Please pulll change: http://udev.netup.ru/hg/v4l-dvb-aospan-22fix/ 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. Description: 22-kHz tone can be driven in two ways: 1. LNBH24 can produce 22kHz continuous tone when TEN=1 ( 22 KHz tone output is always activated ). 2. LNBH24 can reproduce 22kHz tone timings from DSQIN or EXTM pin's when TEN=0. From LNBH24 datasheet: In order to improve design flexibility an external tone input pin is available (EXTM). The EXTM is a Logic input pin which activates the 22 kHz tone output, on the VoTX pin, by using the LNBH24 integrated tone generator (similar to the DSQIN pin function). In fact, the output tone waveform characteristics will always be internally controlled by the LNBH24 tone generator and the EXTM signal will be used as a timing control for DiSEqC tone data encoding on the VoTX output. In NetUP Dual DVB-S2-CI card 22kHz tone timings on EXTM pin produced by STV0900 demod: .set_tone = stv0900_set_tone redefine to set_tone = lnbp21_set_tone is not correct for NetUP Dual DVB-S2-CI card. -- Abylai Ospan aos...@netup.ru NetUP Inc. P.S. Also I think diseqc doesn't work when TEN bit enabled in LNBH24 (22kHz tone can't be modulated by demod), but need to check ... signature.asc Description: This is a digitally signed message part
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hi, Abylai Ospan wrote: Please pulll change: http://udev.netup.ru/hg/v4l-dvb-aospan-22fix/ 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. NAK. Description: 22-kHz tone can be driven in two ways: 1. LNBH24 can produce 22kHz continuous tone when TEN=1 ( 22 KHz tone output is always activated ). 2. LNBH24 can reproduce 22kHz tone timings from DSQIN or EXTM pin's when TEN=0. From LNBH24 datasheet: In order to improve design flexibility an external tone input pin is available (EXTM). The EXTM is a Logic input pin which activates the 22 kHz tone output, on the VoTX pin, by using the LNBH24 integrated tone generator (similar to the DSQIN pin function). In fact, the output tone waveform characteristics will always be internally controlled by the LNBH24 tone generator and the EXTM signal will be used as a timing control for DiSEqC tone data encoding on the VoTX output. In NetUP Dual DVB-S2-CI card 22kHz tone timings on EXTM pin produced by STV0900 demod: .set_tone = stv0900_set_tone redefine to set_tone = lnbp21_set_tone is not correct for NetUP Dual DVB-S2-CI card. Why is it not correct? Please explain. Afaics it does not matter, whether the demod or the LNBH24 controls the 22kHz tone. With your patch, lnbp21_set_tone would never be used... CU Oliver -- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ 4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/ Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hi, Abylai Ospan wrote: redefine to set_tone = lnbp21_set_tone is not correct for NetUP Dual DVB-S2-CI card. Why is it not correct? Please explain. Afaics it does not matter, whether the demod or the LNBH24 controls the 22kHz tone. With your patch, lnbp21_set_tone would never be used... LNBH24 can _continuously_ produce 22kHz tone. This way acceptable if you only want to switch LNB's oscillator to high band. If you want to send diseqc command you need to modulate this 22kHz tone. LNBH24 can't do this but STV0900 demod can. There is no reason why we have to use the set_tone routine of the stv0900. You can combine - set_tone of LNBH24 with - stv090x_send_diseqc_msg of stv0900 without losing anything. Before a DiSEqC message will be sent, the tone will be disabled. Then the stv090x_send_diseqc_msg of the stv0900 can control the 22kHz tone generator of the LNBH24 using EXTM or DSQIN. I have created some demonstration from oscilloscope on NetUP Dual DVB-S2-CI card in attachment ( sorry, russian interface :). Blue is a EXTM pin, yellow is a coaxial connector. As you can see STV0900 sends 11 period's and LNBH24 reproduce it to coaxial output. This is so colled diseqc modulated mode. Scheme of modulated signals you can find in diseqc bus specification - http://www.eutelsat.com/satellites/pdf/Diseqc/Reference% 20docs/bus_spec.pdf on Figure 1: DiSEqC Modulation Scheme. See above. The 22kHz output of the LNBH24 is a logical 'or' of the TEN flag and the control inputs. I don't see any problem here. I think lnbp21_set_tone will be used if set_tone is not defined previously (set_tone == NULL). Is this correct ? No, sorry. set_tone had to be added, because the stv0900 can also operate in DiSEqC envelope mode (connected to DSQIN of the LNBH24). In this mode set_tone of the LNBH24 has to be used. When I modified the lnbp21 module, I considered both cases. I could not (and cannot) see any problem here. Please revert the patch. CU Oliver -- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ 4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/ Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
