Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2018-01-22 Thread Smitha T Murthy
On Mon, 2018-01-22 at 12:08 +0100, Hans Verkuil wrote: > On 08/12/17 10:08, Smitha T Murthy wrote: > > Add v4l2 controls for HEVC encoder > > > > Signed-off-by: Smitha T Murthy > > Reviewed-by: Andrzej Hajda > > --- > > drivers/media/v4l2-core/v4l2-ctrls.c | 118 > > +++

Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2018-01-22 Thread Hans Verkuil
On 08/12/17 10:08, Smitha T Murthy wrote: > Add v4l2 controls for HEVC encoder > > Signed-off-by: Smitha T Murthy > Reviewed-by: Andrzej Hajda > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 118 > +++ > include/uapi/linux/v4l2-controls.h | 92

Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2017-12-13 Thread Smitha T Murthy
On Tue, 2017-12-12 at 10:46 +0100, Sylwester Nawrocki wrote: > On 12/12/2017 03:34 AM, Smitha T Murthy wrote: > >> s/Lay/Layer here and below > >> > > Ok I will change it. > > While it's fine to make such change for controls up to > V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_QP... > > >>> + case V4

Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2017-12-12 Thread Sylwester Nawrocki
On 12/12/2017 03:34 AM, Smitha T Murthy wrote: >> s/Lay/Layer here and below >> > Ok I will change it. While it's fine to make such change for controls up to V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_QP... >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_QP:return "HEVC >>> Hierarchic

Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2017-12-11 Thread Smitha T Murthy
On Sat, 2017-12-09 at 20:48 +0200, Stanimir Varbanov wrote: > Hi Smitha, > > Thanks for the patches! > > On 12/08/2017 11:08 AM, Smitha T Murthy wrote: > > Add v4l2 controls for HEVC encoder > > > > Signed-off-by: Smitha T Murthy > > Reviewed-by: Andrzej Hajda > > --- > > drivers/media/v4l2-c

Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2017-12-09 Thread Stanimir Varbanov
Hi Smitha, Thanks for the patches! On 12/08/2017 11:08 AM, Smitha T Murthy wrote: Add v4l2 controls for HEVC encoder Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda --- drivers/media/v4l2-core/v4l2-ctrls.c | 118 +++ include/uapi/linux/v4l2-controls

[Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2017-12-08 Thread Smitha T Murthy
Add v4l2 controls for HEVC encoder Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda --- drivers/media/v4l2-core/v4l2-ctrls.c | 118 +++ include/uapi/linux/v4l2-controls.h | 92 ++- 2 files changed, 209 insertions(+), 1 deletion