Re: [RESEND PATCH 1/14] staging/media/as102: initial import from Abilis
On 10/30/2011 10:03 PM, Piotr Chmura wrote: W dniu 18.10.2011 21:46, Piotr Chmura pisze: Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/ Changes made by me: 1. Driver moved from media/dvb to staging/media 2. Removed Makefile/Kconfig - it doesn't compile in current tree (...) + +/* + * Note: + * - in AS102 SNR=MER + * - the SNR will be returned in linear terms, i.e. not in dB + * - the accuracy equals ±2dB for a SNR range from 4dB to 30dB + * - the accuracy is2dB for SNR values outside this range + */ I found another issue here. In this comment ± is from upper ASCII (0xF1). Should I change it into sth. like +/- in this patch (1/14) or leave it and just resend without  (wasn't there in original patch, don't know where it came from) ? I collected all your patches (1..14/14, as we agreed in private), did a bit of cleanup myself, re-edited the changelogs and I'm going to post the series which is hopefully ready for initial pull into staging/media. I've also removed that odd  character right from the first patch. Peter P.S. Thanks to Sylwester Nawrocki for pointing me out, that there is something wrong with patch 6/14, which was caused by this comment in 1/14. --- Regards, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND PATCH 1/14] staging/media/as102: initial import from Abilis
W dniu 18.10.2011 21:46, Piotr Chmura pisze: Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/ Changes made by me: 1. Driver moved from media/dvb to staging/media 2. Removed Makefile/Kconfig - it doesn't compile in current tree (...) + +/* + * Note: + * - in AS102 SNR=MER + * - the SNR will be returned in linear terms, i.e. not in dB + * - the accuracy equals ±2dB for a SNR range from 4dB to 30dB + * - the accuracy is2dB for SNR values outside this range + */ I found another issue here. In this comment ± is from upper ASCII (0xF1). Should I change it into sth. like +/- in this patch (1/14) or leave it and just resend without  (wasn't there in original patch, don't know where it came from) ? Peter P.S. Thanks to Sylwester Nawrocki for pointing me out, that there is something wrong with patch 6/14, which was caused by this comment in 1/14. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND PATCH 1/14] staging/media/as102: initial import from Abilis
On Oct 30 Piotr Chmura wrote: + * Note: + * - in AS102 SNR=MER + * - the SNR will be returned in linear terms, i.e. not in dB + * - the accuracy equals ±2dB for a SNR range from 4dB to 30dB + * - the accuracy is2dB for SNR values outside this range + */ I found another issue here. In this comment ± is from upper ASCII (0xF1). Should I change it into sth. like +/- in this patch (1/14) or leave it and just resend without  (wasn't there in original patch, don't know where it came from) ? Special characters can be used in comments, provided that they are UTF-8 encoded. In case of names of persons or companies, it is very much desirable to preserve special characters. In case like this one on the other hand, sticking with ASCII (the 7 bit character table) might not be such a bad idea to keep things simple. But since you are passing on a patch from somebody else, the right thing to do is IMO to keep the special characters that the author chose and only make sure that the file (and the patch mailing) are UTF-8 encoded. -- Stefan Richter -=-==-== =-=- - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
