Re: [RFC/PATCH 1/5] vpif_cap/disp: Add debug functionality

2010-10-24 Thread Muralidharan Karicheri
My previous reply didn't make it to linuxtv server. See comments below. On Sun, Oct 24, 2010 at 10:04 AM, Muralidharan Karicheri wrote: > Thanks for the patch. Please read below for my comments > > >> >> +/* >> + * vpif_g_chip_ident() - Identify the chip >> + * @file: file ptr >> + * @priv: file

RE: [RFC/PATCH 1/5] vpif_cap/disp: Add debug functionality

2010-10-23 Thread Hiremath, Vaibhav
> -Original Message- > From: mats.randga...@tandberg.com [mailto:mats.randga...@tandberg.com] > Sent: Friday, October 22, 2010 12:31 PM > To: Hiremath, Vaibhav > Cc: linux-media@vger.kernel.org; hans.verk...@tandberg.com; Mats Randgaard > Subject: [RFC/PATCH 1/5] vpif_c

[RFC/PATCH 1/5] vpif_cap/disp: Add debug functionality

2010-10-22 Thread mats . randgaard
From: Mats Randgaard The following functions are added to the drivers: - vpif_g_chip_ident - vpif_dbg_g_register - vpif_dbg_s_register - vpif_log_status Signed-off-by: Mats Randgaard Signed-off-by: Hans Verkuil --- drivers/media/video/davinci/vpif_capture.c | 87