Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-27 Thread Laurent Pinchart
Hi Hans, On Monday 26 July 2010 21:48:28 Hans Verkuil wrote: On Monday 26 July 2010 18:34:42 Laurent Pinchart wrote: On Saturday 24 July 2010 14:45:39 Hans Verkuil wrote: On Wednesday 21 July 2010 16:35:31 Laurent Pinchart wrote: Create the following two ioctls and implement them at the

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-26 Thread Laurent Pinchart
Hi Pete, On Thursday 22 July 2010 18:36:51 Pete Eberlein wrote: On Thu, 2010-07-22 at 17:20 +0200, Laurent Pinchart wrote: Laurent Pinchart wrote: ... diff --git a/Documentation/media-framework.txt b/Documentation/media-framework.txt index 3acc62b..16c0177 100644 ---

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-26 Thread Laurent Pinchart
Hi Sakari, On Thursday 22 July 2010 19:30:21 Sakari Ailus wrote: Laurent Pinchart wrote: + +struct media_user_pad { + __u32 entity; /* entity ID */ + __u8 index; /* pad index */ + __u32 direction;/* pad direction */ +}; Another small comment, I

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-26 Thread Laurent Pinchart
Hi Hans, On Saturday 24 July 2010 14:45:39 Hans Verkuil wrote: On Wednesday 21 July 2010 16:35:31 Laurent Pinchart wrote: Create the following two ioctls and implement them at the media device level to enumerate entities, pads and links. - MEDIA_IOC_ENUM_ENTITIES: Enumerate entities and

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-26 Thread Hans Verkuil
On Monday 26 July 2010 18:34:42 Laurent Pinchart wrote: Hi Hans, On Saturday 24 July 2010 14:45:39 Hans Verkuil wrote: On Wednesday 21 July 2010 16:35:31 Laurent Pinchart wrote: Create the following two ioctls and implement them at the media device level to enumerate entities, pads and

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-24 Thread Hans Verkuil
On Wednesday 21 July 2010 16:35:31 Laurent Pinchart wrote: Create the following two ioctls and implement them at the media device level to enumerate entities, pads and links. - MEDIA_IOC_ENUM_ENTITIES: Enumerate entities and their properties - MEDIA_IOC_ENUM_LINKS: Enumerate all pads and

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-22 Thread Sakari Ailus
Heippa, What a nice patch! :-) Laurent Pinchart wrote: ... diff --git a/Documentation/media-framework.txt b/Documentation/media-framework.txt index 3acc62b..16c0177 100644 --- a/Documentation/media-framework.txt +++ b/Documentation/media-framework.txt @@ -270,3 +270,137 @@ required,

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-22 Thread Laurent Pinchart
Hi Sakari, On Thursday 22 July 2010 17:10:01 Sakari Ailus wrote: Heippa, What a nice patch! :-) Thanks :-) Laurent Pinchart wrote: ... diff --git a/Documentation/media-framework.txt b/Documentation/media-framework.txt index 3acc62b..16c0177 100644 ---

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-22 Thread Sakari Ailus
Hi, Laurent Pinchart wrote: ... diff --git a/include/linux/media.h b/include/linux/media.h new file mode 100644 index 000..746bdda --- /dev/null +++ b/include/linux/media.h @@ -0,0 +1,73 @@ +#ifndef __LINUX_MEDIA_H +#define __LINUX_MEDIA_H + +#define MEDIA_ENTITY_TYPE_NODE

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-22 Thread Laurent Pinchart
Hi Sakari, On Thursday 22 July 2010 17:26:55 Sakari Ailus wrote: Hi, Laurent Pinchart wrote: ... diff --git a/include/linux/media.h b/include/linux/media.h new file mode 100644 index 000..746bdda --- /dev/null +++ b/include/linux/media.h @@ -0,0 +1,73 @@ [snip] +

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-22 Thread Sakari Ailus
Laurent Pinchart wrote: That change causes a lot of clashes in naming since the equivalent kernel structure is there as well. Those could have _k postfix, for example, to differentiate them from user space names. I don't really have a good suggestion how they should be called. Maybe

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-22 Thread Pete Eberlein
On Thu, 2010-07-22 at 17:20 +0200, Laurent Pinchart wrote: Laurent Pinchart wrote: ... diff --git a/Documentation/media-framework.txt b/Documentation/media-framework.txt index 3acc62b..16c0177 100644 --- a/Documentation/media-framework.txt +++

Re: [RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-22 Thread Sakari Ailus
Laurent Pinchart wrote: Hi Sakari, Hello Laurent, ... + +struct media_user_pad { + __u32 entity; /* entity ID */ + __u8 index; /* pad index */ + __u32 direction;/* pad direction */ +}; Another small comment, I think you mentioned it yourself some time

[RFC/PATCH v2 06/10] media: Entities, pads and links enumeration

2010-07-21 Thread Laurent Pinchart
Create the following two ioctls and implement them at the media device level to enumerate entities, pads and links. - MEDIA_IOC_ENUM_ENTITIES: Enumerate entities and their properties - MEDIA_IOC_ENUM_LINKS: Enumerate all pads and links for a given entity Entity IDs can be non-contiguous.