Re: [RFC/PATCH v5 01/12] media: Media device node support

2010-11-22 Thread Hans Verkuil
On Monday, November 22, 2010 00:35:54 Laurent Pinchart wrote: Hi Jonathan, I forgot to answer one of your comments. On Wednesday 17 November 2010 01:31:15 Jonathan Corbet wrote: [snip] +static unsigned int media_poll(struct file *filp, +struct

Re: [RFC/PATCH v5 01/12] media: Media device node support

2010-11-21 Thread Laurent Pinchart
Hi Jonathan, I forgot to answer one of your comments. On Wednesday 17 November 2010 01:31:15 Jonathan Corbet wrote: [snip] +static unsigned int media_poll(struct file *filp, + struct poll_table_struct *poll) +{ + struct media_devnode *mdev =

Re: [RFC/PATCH v5 01/12] media: Media device node support

2010-11-17 Thread Laurent Pinchart
Hi Jonathan, On Wednesday 17 November 2010 01:31:15 Jonathan Corbet wrote: Here's the first of my more specific comments - probably the only file I'll get to today... Thanks a lot for the review ! The media_devnode structure provides support for registering and unregistering character

Re: [RFC/PATCH v5 01/12] media: Media device node support

2010-11-16 Thread Jonathan Corbet
Here's the first of my more specific comments - probably the only file I'll get to today... The media_devnode structure provides support for registering and unregistering character devices using a dynamic major number. Reference counting is handled internally, making device drivers easier to

[RFC/PATCH v5 01/12] media: Media device node support

2010-09-23 Thread Laurent Pinchart
The media_devnode structure provides support for registering and unregistering character devices using a dynamic major number. Reference counting is handled internally, making device drivers easier to write without having to solve the open/disconnect race condition issue over and over again. The