Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-10 Thread Laurent Pinchart
Hi Greg, On Thursday 06 January 2011 23:19:12 Greg KH wrote: > On Fri, Dec 24, 2010 at 12:59:38PM +0100, Laurent Pinchart wrote: > > On Thursday 23 December 2010 04:32:53 Greg KH wrote: > > > On Mon, Dec 20, 2010 at 12:36:24PM +0100, Laurent Pinchart wrote: > > > > +config MEDIA_CONTROLLER > > > >

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Andy Walls
Yeah well, lame-o default email client on my Android phone. -Andy Greg KH wrote: > > >A: No. >Q: Should I include quotations after my reply? > >http://daringfireball.net/2007/07/on_top > >On Thu, Jan 06, 2011 at 07:24:27PM -0500, Andy Walls wrote: >> Why, yes, there is a standard: >> >> http:/

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Jan 06, 2011 at 07:24:27PM -0500, Andy Walls wrote: > Why, yes, there is a standard: > > http://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_03.html > > A somewhat verbose de

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Andy Walls
Why, yes, there is a standard: http://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_03.html A somewhat verbose description of the errnos is in section 2.3. -Andy Hans Verkuil wrote: >On Thursday, January 06, 2011 23:19:12 Greg KH wrote: > > > >> > > > +static ssize_t media_read

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Greg KH
On Fri, Jan 07, 2011 at 12:27:11AM +0100, Hans Verkuil wrote: > On Thursday, January 06, 2011 23:19:12 Greg KH wrote: > > > > > > > > +static ssize_t media_read(struct file *filp, char __user *buf, > > > > > + size_t sz, loff_t *off) > > > > > +{ > > > > > + struct media_devnode

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Hans Verkuil
On Thursday, January 06, 2011 23:19:12 Greg KH wrote: > > > > +static ssize_t media_read(struct file *filp, char __user *buf, > > > > + size_t sz, loff_t *off) > > > > +{ > > > > + struct media_devnode *mdev = media_devnode_data(filp); > > > > + > > > > + if (!mdev->fop

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Greg KH
On Fri, Dec 24, 2010 at 12:59:38PM +0100, Laurent Pinchart wrote: > Hi Greg, > > Thank you for the review. > > On Thursday 23 December 2010 04:32:53 Greg KH wrote: > > On Mon, Dec 20, 2010 at 12:36:24PM +0100, Laurent Pinchart wrote: > > > The media_devnode structure provides support for register

Re: [RFC/PATCH v7 01/12] media: Media device node support

2010-12-24 Thread Laurent Pinchart
Hi Greg, Thank you for the review. On Thursday 23 December 2010 04:32:53 Greg KH wrote: > On Mon, Dec 20, 2010 at 12:36:24PM +0100, Laurent Pinchart wrote: > > The media_devnode structure provides support for registering and > > unregistering character devices using a dynamic major number. Refere

Re: [RFC/PATCH v7 01/12] media: Media device node support

2010-12-22 Thread Greg KH
On Mon, Dec 20, 2010 at 12:36:24PM +0100, Laurent Pinchart wrote: > +/* > + * Flag to mark the media_devnode struct as registered. Drivers must not > touch > + * this flag directly, it will be set and cleared by media_devnode_register > and > + * media_devnode_unregister. > + */ > +#define MEDIA_

Re: [RFC/PATCH v7 01/12] media: Media device node support

2010-12-22 Thread Greg KH
On Mon, Dec 20, 2010 at 12:36:24PM +0100, Laurent Pinchart wrote: > The media_devnode structure provides support for registering and > unregistering character devices using a dynamic major number. Reference > counting is handled internally, making device drivers easier to write > without having to

[RFC/PATCH v7 01/12] media: Media device node support

2010-12-20 Thread Laurent Pinchart
The media_devnode structure provides support for registering and unregistering character devices using a dynamic major number. Reference counting is handled internally, making device drivers easier to write without having to solve the open/disconnect race condition issue over and over again. The c