Re: [RFC 09/10 v2] v4l2-subdev: re-add s_standby to v4l2_subdev_core_ops

2009-05-23 Thread Guennadi Liakhovetski
On Sat, 23 May 2009, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > I think we can put the camera to a low-power state in streamoff. But - not > > power it off! This has to be done from system's PM functions. > That means, from a sensor POV, through icd->stop_capture(). > For my si

Re: [RFC 09/10 v2] v4l2-subdev: re-add s_standby to v4l2_subdev_core_ops

2009-05-23 Thread Robert Jarzmik
Guennadi Liakhovetski writes: >> Let me be even more precise about a usecase : >> - a user takes a picture with his smartphone >> - the same user then uses his phone to call his girlfriend >> - the girlfriend has a lot of things to say, it lasts for 1 hour >> In that case, the sensor _has_ to

Re: [RFC 09/10 v2] v4l2-subdev: re-add s_standby to v4l2_subdev_core_ops

2009-05-22 Thread Guennadi Liakhovetski
On Fri, 22 May 2009, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > >> Usual question: why do you need an init and halt? What do they do? > > > > Hm, maybe you're right, I don't need them. init() was used in soc_camera > > drivers on first open() to possibly reset the chip and put it

Re: [RFC 09/10 v2] v4l2-subdev: re-add s_standby to v4l2_subdev_core_ops

2009-05-22 Thread Robert Jarzmik
Guennadi Liakhovetski writes: >> Usual question: why do you need an init and halt? What do they do? > > Hm, maybe you're right, I don't need them. init() was used in soc_camera > drivers on first open() to possibly reset the chip and put it in some > reasonably pre-defined low-power state. But

Re: [RFC 09/10 v2] v4l2-subdev: re-add s_standby to v4l2_subdev_core_ops

2009-05-22 Thread Hans Verkuil
On Friday 22 May 2009 16:23:36 Guennadi Liakhovetski wrote: > On Thu, 21 May 2009, Hans Verkuil wrote: > > On Friday 15 May 2009 19:20:18 Guennadi Liakhovetski wrote: > > > NOT FOR SUBMISSION. Probably, another solution has to be found. > > > soc-camera drivers need an .init() (marked as "don't use

Re: [RFC 09/10 v2] v4l2-subdev: re-add s_standby to v4l2_subdev_core_ops

2009-05-22 Thread Guennadi Liakhovetski
On Thu, 21 May 2009, Hans Verkuil wrote: > On Friday 15 May 2009 19:20:18 Guennadi Liakhovetski wrote: > > NOT FOR SUBMISSION. Probably, another solution has to be found. > > soc-camera drivers need an .init() (marked as "don't use") and a .halt() > > methods. > > > > Signed-off-by: Guennadi Liakh

Re: [RFC 09/10 v2] v4l2-subdev: re-add s_standby to v4l2_subdev_core_ops

2009-05-21 Thread Hans Verkuil
On Friday 15 May 2009 19:20:18 Guennadi Liakhovetski wrote: > NOT FOR SUBMISSION. Probably, another solution has to be found. > soc-camera drivers need an .init() (marked as "don't use") and a .halt() > methods. > > Signed-off-by: Guennadi Liakhovetski > --- > > Hans, you moved s_standby to tuner_

[RFC 09/10 v2] v4l2-subdev: re-add s_standby to v4l2_subdev_core_ops

2009-05-15 Thread Guennadi Liakhovetski
NOT FOR SUBMISSION. Probably, another solution has to be found. soc-camera drivers need an .init() (marked as "don't use") and a .halt() methods. Signed-off-by: Guennadi Liakhovetski --- Hans, you moved s_standby to tuner_ops, and init is not recommended for new drivers. Suggestions? include/