Re: [RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-09 Thread Ohad Ben-Cohen
On Wed, Jun 8, 2011 at 1:46 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Tuesday 07 June 2011 15:46:26 Ohad Ben-Cohen wrote: Where do you take care of those potential offsets today ? Or do you simply ignore the offsets and map the entire page ? Here

Re: [RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-08 Thread Laurent Pinchart
Hi Ohad, On Tuesday 07 June 2011 15:46:26 Ohad Ben-Cohen wrote: On Tue, Jun 7, 2011 at 2:26 PM, Laurent Pinchart wrote: Right now we have a BUG_ON if pa is unaligned, but that can be changed if needed (do we want it to handle offsets ?). At least for the OMAP3 ISP we need to, as video

Re: [RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-07 Thread Laurent Pinchart
Hi Ohad, Thanks for the patch. On Friday 03 June 2011 00:27:39 Ohad Ben-Cohen wrote: Migrate omap's iovmm (virtual memory manager) to the generic iommu api. This brings iovmm a step forward towards being completely non omap-specific (it's still assuming omap's iommu page sizes, and also

Re: [RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-07 Thread Ohad Ben-Cohen
Hi Laurent, On Tue, Jun 7, 2011 at 12:05 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: pgsz isn't used anymore, you can remove it. Ok. +             order = get_order(bytes); Does iommu_map() handle offsets correctly, or does it expect pa to be aligned to an order (or

Re: [RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-07 Thread Laurent Pinchart
Hi Ohad, On Tuesday 07 June 2011 12:28:53 Ohad Ben-Cohen wrote: On Tue, Jun 7, 2011 at 12:05 PM, Laurent Pinchart wrote: pgsz isn't used anymore, you can remove it. Ok. + order = get_order(bytes); Does iommu_map() handle offsets correctly, or does it expect pa to be

Re: [RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-07 Thread Ohad Ben-Cohen
Hi Laurent, On Tue, Jun 7, 2011 at 2:26 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Right now we have a BUG_ON if pa is unaligned, but that can be changed if needed (do we want it to handle offsets ?). At least for the OMAP3 ISP we need to, as video buffers don't necessarily

[RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-02 Thread Ohad Ben-Cohen
Migrate omap's iovmm (virtual memory manager) to the generic iommu api. This brings iovmm a step forward towards being completely non omap-specific (it's still assuming omap's iommu page sizes, and also maintaining state inside omap's internal iommu structure, but it no longer calls omap-specific