Re: [RFC PATCH 2/8] v4l2-subdev: drop get/set_crop pad ops

2014-12-16 Thread Prabhakar Lad 
On Thu, Dec 4, 2014 at 3:24 PM, Hans Verkuil hverk...@xs4all.nl wrote:
 From: Hans Verkuil hans.verk...@cisco.com

 Drop the duplicate get/set_crop pad ops and only use get/set_selection.
 It makes no sense to have two duplicate ops in the internal subdev API.

 Signed-off-by: Hans Verkuil hans.verk...@cisco.com
 Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com

Regards,
--Prabhakar Lad

 ---
  drivers/media/v4l2-core/v4l2-subdev.c | 8 
  include/media/v4l2-subdev.h   | 4 
  2 files changed, 12 deletions(-)

 diff --git a/drivers/media/v4l2-core/v4l2-subdev.c 
 b/drivers/media/v4l2-core/v4l2-subdev.c
 index 543631c..19a034e 100644
 --- a/drivers/media/v4l2-core/v4l2-subdev.c
 +++ b/drivers/media/v4l2-core/v4l2-subdev.c
 @@ -283,10 +283,6 @@ static long subdev_do_ioctl(struct file *file, unsigned 
 int cmd, void *arg)
 if (rval)
 return rval;

 -   rval = v4l2_subdev_call(sd, pad, get_crop, subdev_fh, crop);
 -   if (rval != -ENOIOCTLCMD)
 -   return rval;
 -
 memset(sel, 0, sizeof(sel));
 sel.which = crop-which;
 sel.pad = crop-pad;
 @@ -308,10 +304,6 @@ static long subdev_do_ioctl(struct file *file, unsigned 
 int cmd, void *arg)
 if (rval)
 return rval;

 -   rval = v4l2_subdev_call(sd, pad, set_crop, subdev_fh, crop);
 -   if (rval != -ENOIOCTLCMD)
 -   return rval;
 -
 memset(sel, 0, sizeof(sel));
 sel.which = crop-which;
 sel.pad = crop-pad;
 diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
 index 5860292..b052184 100644
 --- a/include/media/v4l2-subdev.h
 +++ b/include/media/v4l2-subdev.h
 @@ -503,10 +503,6 @@ struct v4l2_subdev_pad_ops {
struct v4l2_subdev_format *format);
 int (*set_fmt)(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
struct v4l2_subdev_format *format);
 -   int (*set_crop)(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
 -  struct v4l2_subdev_crop *crop);
 -   int (*get_crop)(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
 -  struct v4l2_subdev_crop *crop);
 int (*get_selection)(struct v4l2_subdev *sd, struct v4l2_subdev_fh 
 *fh,
  struct v4l2_subdev_selection *sel);
 int (*set_selection)(struct v4l2_subdev *sd, struct v4l2_subdev_fh 
 *fh,
 --
 2.1.3

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 2/8] v4l2-subdev: drop get/set_crop pad ops

2014-12-12 Thread Sakari Ailus 
On Thu, Dec 04, 2014 at 10:54:53AM +0100, Hans Verkuil wrote:
 From: Hans Verkuil hans.verk...@cisco.com
 
 Drop the duplicate get/set_crop pad ops and only use get/set_selection.
 It makes no sense to have two duplicate ops in the internal subdev API.
 
 Signed-off-by: Hans Verkuil hans.verk...@cisco.com
 Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com


Acked-by: Sakari Ailus sakari.ai...@linux.intel.com

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC PATCH 2/8] v4l2-subdev: drop get/set_crop pad ops

2014-12-04 Thread Hans Verkuil 
From: Hans Verkuil hans.verk...@cisco.com

Drop the duplicate get/set_crop pad ops and only use get/set_selection.
It makes no sense to have two duplicate ops in the internal subdev API.

Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
 drivers/media/v4l2-core/v4l2-subdev.c | 8 
 include/media/v4l2-subdev.h   | 4 
 2 files changed, 12 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-subdev.c 
b/drivers/media/v4l2-core/v4l2-subdev.c
index 543631c..19a034e 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -283,10 +283,6 @@ static long subdev_do_ioctl(struct file *file, unsigned 
int cmd, void *arg)
if (rval)
return rval;
 
-   rval = v4l2_subdev_call(sd, pad, get_crop, subdev_fh, crop);
-   if (rval != -ENOIOCTLCMD)
-   return rval;
-
memset(sel, 0, sizeof(sel));
sel.which = crop-which;
sel.pad = crop-pad;
@@ -308,10 +304,6 @@ static long subdev_do_ioctl(struct file *file, unsigned 
int cmd, void *arg)
if (rval)
return rval;
 
-   rval = v4l2_subdev_call(sd, pad, set_crop, subdev_fh, crop);
-   if (rval != -ENOIOCTLCMD)
-   return rval;
-
memset(sel, 0, sizeof(sel));
sel.which = crop-which;
sel.pad = crop-pad;
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index 5860292..b052184 100644
--- a/include/media/v4l2-subdev.h
+++ b/include/media/v4l2-subdev.h
@@ -503,10 +503,6 @@ struct v4l2_subdev_pad_ops {
   struct v4l2_subdev_format *format);
int (*set_fmt)(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
   struct v4l2_subdev_format *format);
-   int (*set_crop)(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
-  struct v4l2_subdev_crop *crop);
-   int (*get_crop)(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
-  struct v4l2_subdev_crop *crop);
int (*get_selection)(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
 struct v4l2_subdev_selection *sel);
int (*set_selection)(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
-- 
2.1.3

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html