Re: [RFC PATCH 3/8] v4l2-subdev: drop unused op enum_mbus_fmt

2014-12-19 Thread Hans Verkuil 


On 12/18/2014 11:08 PM, Guennadi Liakhovetski wrote:
 Hi Hans,
 
 On Thu, 4 Dec 2014, Hans Verkuil wrote:
 
 From: Hans Verkuil hans.verk...@cisco.com

 Weird, this op isn't used at all. Seems to be orphaned code.
 Remove it.

 Signed-off-by: Hans Verkuil hans.verk...@cisco.com
 ---
  include/media/v4l2-subdev.h | 2 --
  1 file changed, 2 deletions(-)

 diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
 index b052184..5beeb87 100644
 --- a/include/media/v4l2-subdev.h
 +++ b/include/media/v4l2-subdev.h
 @@ -342,8 +342,6 @@ struct v4l2_subdev_video_ops {
  struct v4l2_dv_timings *timings);
  int (*enum_mbus_fmt)(struct v4l2_subdev *sd, unsigned int index,
   u32 *code);
 -int (*enum_mbus_fsizes)(struct v4l2_subdev *sd,
 - struct v4l2_frmsizeenum *fsize);
 
 After so many cheerful acks I feel a bit bluffed, but... Your subject says 
 drop enum_mbus_fmt and your patch drops enum_mbus_fsizes... What am I 
 missing??

Oops. Obviously the function name in the subject is wrong.

Interesting that everyone (except you!) just read over that :-)

Regards,

Hans

 
 Thanks
 Guennadi
 
  int (*g_mbus_fmt)(struct v4l2_subdev *sd,
struct v4l2_mbus_framefmt *fmt);
  int (*try_mbus_fmt)(struct v4l2_subdev *sd,
 -- 
 2.1.3

 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 3/8] v4l2-subdev: drop unused op enum_mbus_fmt

2014-12-18 Thread Guennadi Liakhovetski 
Hi Hans,

On Thu, 4 Dec 2014, Hans Verkuil wrote:

 From: Hans Verkuil hans.verk...@cisco.com
 
 Weird, this op isn't used at all. Seems to be orphaned code.
 Remove it.
 
 Signed-off-by: Hans Verkuil hans.verk...@cisco.com
 ---
  include/media/v4l2-subdev.h | 2 --
  1 file changed, 2 deletions(-)
 
 diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
 index b052184..5beeb87 100644
 --- a/include/media/v4l2-subdev.h
 +++ b/include/media/v4l2-subdev.h
 @@ -342,8 +342,6 @@ struct v4l2_subdev_video_ops {
   struct v4l2_dv_timings *timings);
   int (*enum_mbus_fmt)(struct v4l2_subdev *sd, unsigned int index,
u32 *code);
 - int (*enum_mbus_fsizes)(struct v4l2_subdev *sd,
 -  struct v4l2_frmsizeenum *fsize);

After so many cheerful acks I feel a bit bluffed, but... Your subject says 
drop enum_mbus_fmt and your patch drops enum_mbus_fsizes... What am I 
missing??

Thanks
Guennadi

   int (*g_mbus_fmt)(struct v4l2_subdev *sd,
 struct v4l2_mbus_framefmt *fmt);
   int (*try_mbus_fmt)(struct v4l2_subdev *sd,
 -- 
 2.1.3
 
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 3/8] v4l2-subdev: drop unused op enum_mbus_fmt

2014-12-16 Thread Prabhakar Lad 
On Thu, Dec 4, 2014 at 3:24 PM, Hans Verkuil hverk...@xs4all.nl wrote:
 From: Hans Verkuil hans.verk...@cisco.com

 Weird, this op isn't used at all. Seems to be orphaned code.
 Remove it.

 Signed-off-by: Hans Verkuil hans.verk...@cisco.com

Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com

Regards,
--Prabhakar Lad

 ---
  include/media/v4l2-subdev.h | 2 --
  1 file changed, 2 deletions(-)

 diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
 index b052184..5beeb87 100644
 --- a/include/media/v4l2-subdev.h
 +++ b/include/media/v4l2-subdev.h
 @@ -342,8 +342,6 @@ struct v4l2_subdev_video_ops {
 struct v4l2_dv_timings *timings);
 int (*enum_mbus_fmt)(struct v4l2_subdev *sd, unsigned int index,
  u32 *code);
 -   int (*enum_mbus_fsizes)(struct v4l2_subdev *sd,
 -struct v4l2_frmsizeenum *fsize);
 int (*g_mbus_fmt)(struct v4l2_subdev *sd,
   struct v4l2_mbus_framefmt *fmt);
 int (*try_mbus_fmt)(struct v4l2_subdev *sd,
 --
 2.1.3

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 3/8] v4l2-subdev: drop unused op enum_mbus_fmt

2014-12-12 Thread Sakari Ailus 
On Thu, Dec 04, 2014 at 10:54:54AM +0100, Hans Verkuil wrote:
 From: Hans Verkuil hans.verk...@cisco.com
 
 Weird, this op isn't used at all. Seems to be orphaned code.
 Remove it.
 
 Signed-off-by: Hans Verkuil hans.verk...@cisco.com

Acked-by: Sakari Ailus sakari.ai...@linux.intel.com

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 3/8] v4l2-subdev: drop unused op enum_mbus_fmt

2014-12-07 Thread Laurent Pinchart 
Hi Hans,

Thank you for the patch.

On Thursday 04 December 2014 10:54:54 Hans Verkuil wrote:
 From: Hans Verkuil hans.verk...@cisco.com
 
 Weird, this op isn't used at all. Seems to be orphaned code.
 Remove it.
 
 Signed-off-by: Hans Verkuil hans.verk...@cisco.com

That's easy, I like it :-)

Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

 ---
  include/media/v4l2-subdev.h | 2 --
  1 file changed, 2 deletions(-)
 
 diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
 index b052184..5beeb87 100644
 --- a/include/media/v4l2-subdev.h
 +++ b/include/media/v4l2-subdev.h
 @@ -342,8 +342,6 @@ struct v4l2_subdev_video_ops {
   struct v4l2_dv_timings *timings);
   int (*enum_mbus_fmt)(struct v4l2_subdev *sd, unsigned int index,
u32 *code);
 - int (*enum_mbus_fsizes)(struct v4l2_subdev *sd,
 -  struct v4l2_frmsizeenum *fsize);
   int (*g_mbus_fmt)(struct v4l2_subdev *sd,
 struct v4l2_mbus_framefmt *fmt);
   int (*try_mbus_fmt)(struct v4l2_subdev *sd,

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC PATCH 3/8] v4l2-subdev: drop unused op enum_mbus_fmt

2014-12-04 Thread Hans Verkuil 
From: Hans Verkuil hans.verk...@cisco.com

Weird, this op isn't used at all. Seems to be orphaned code.
Remove it.

Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
 include/media/v4l2-subdev.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index b052184..5beeb87 100644
--- a/include/media/v4l2-subdev.h
+++ b/include/media/v4l2-subdev.h
@@ -342,8 +342,6 @@ struct v4l2_subdev_video_ops {
struct v4l2_dv_timings *timings);
int (*enum_mbus_fmt)(struct v4l2_subdev *sd, unsigned int index,
 u32 *code);
-   int (*enum_mbus_fsizes)(struct v4l2_subdev *sd,
-struct v4l2_frmsizeenum *fsize);
int (*g_mbus_fmt)(struct v4l2_subdev *sd,
  struct v4l2_mbus_framefmt *fmt);
int (*try_mbus_fmt)(struct v4l2_subdev *sd,
-- 
2.1.3

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html