Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-11 Thread Sangwook Lee
Hi Francesco Thanks for your advice. @ Sylwester Thanks for your nice patch, and I will squash and then send it again. Thanks Sangwook On 10 September 2012 21:29, Sylwester Nawrocki wrote: > On 09/10/2012 08:52 PM, Francesco Lavra wrote: >> On 09/10/2012 05:04 PM, Sylwester Nawrocki wrote:

Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-10 Thread Sylwester Nawrocki
On 09/10/2012 08:52 PM, Francesco Lavra wrote: > On 09/10/2012 05:04 PM, Sylwester Nawrocki wrote: >> On 09/09/2012 06:01 PM, Francesco Lavra wrote: +static int s5k4ecgx_load_firmware(struct v4l2_subdev *sd) +{ + const struct firmware *fw; + int err, i, regs_num; + struc

Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-10 Thread Francesco Lavra
Hi, On 09/10/2012 05:04 PM, Sylwester Nawrocki wrote: > Hi, > > On 09/09/2012 06:01 PM, Francesco Lavra wrote: >>> +static int s5k4ecgx_load_firmware(struct v4l2_subdev *sd) >>> +{ >>> + const struct firmware *fw; >>> + int err, i, regs_num; >>> + struct i2c_client *client = v4l2_get_subdev

Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-10 Thread Sylwester Nawrocki
Hi, On 09/09/2012 06:01 PM, Francesco Lavra wrote: >> +static int s5k4ecgx_load_firmware(struct v4l2_subdev *sd) >> +{ >> +const struct firmware *fw; >> +int err, i, regs_num; >> +struct i2c_client *client = v4l2_get_subdevdata(sd); >> +u16 val; >> +u32 addr, crc, crc_file, add

Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-09 Thread Francesco Lavra
Hi, I'm going to report the (few) things which are also present in Sylwester's tree. On 09/06/2012 05:08 PM, Sangwook Lee wrote: > This patch adds driver for S5K4ECGX sensor with embedded ISP SoC, > S5K4ECGX, which is a 5M CMOS Image sensor from Samsung > The driver implements preview mode of the

Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-07 Thread Sylwester Nawrocki
Hi Sangwook, On 09/06/2012 05:08 PM, Sangwook Lee wrote: This patch adds driver for S5K4ECGX sensor with embedded ISP SoC, S5K4ECGX, which is a 5M CMOS Image sensor from Samsung The driver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing no

[RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-06 Thread Sangwook Lee
This patch adds driver for S5K4ECGX sensor with embedded ISP SoC, S5K4ECGX, which is a 5M CMOS Image sensor from Samsung The driver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/saturation/bri