Re: [RFC v4 10/18] vb2: dma-contig: Fix DMA attribute and cache management

2017-05-23 Thread Sakari Ailus
Hi Tomasz, Thanks for the review! Considering where things currently stand, I thing getting the three first patches merged in the near future would make sense. The rest will need a bit more work, and adding buffer flags that aren't used wouldn't really make sense either. See below. On Wed, May

Re: [RFC v4 10/18] vb2: dma-contig: Fix DMA attribute and cache management

2017-05-10 Thread Tomasz Figa
Hi Sakari, Some comments inline. On Mon, May 8, 2017 at 11:03 PM, Sakari Ailus wrote: > Patch ccc66e73 ("ARM: 8508/2: videobuf2-dc: Let drivers specify DMA > attrs") added support for driver specific DMA attributes to > videobuf2-dma-contig but it had several

[RFC v4 10/18] vb2: dma-contig: Fix DMA attribute and cache management

2017-05-08 Thread Sakari Ailus
Patch ccc66e73 ("ARM: 8508/2: videobuf2-dc: Let drivers specify DMA attrs") added support for driver specific DMA attributes to videobuf2-dma-contig but it had several issues in it. In particular, - cache operations were only performed on USERPTR buffers, - DMA attributes were set only for MMAP