Re: [RFCv2 PATCH 05/21] videodev2.h: add struct v4l2_query_ext_ctrl and VIDIOC_QUERY_EXT_CTRL.

2014-01-24 Thread Hans Verkuil
Hi Sakari, On 01/24/2014 12:28 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, Jan 20, 2014 at 01:45:58PM +0100, Hans Verkuil wrote: >> +union { >> +__u64 val; >> +__u32 reserved[4]; >> +} step; > > While I do not question that step is obviously always a positive v

Re: [RFCv2 PATCH 05/21] videodev2.h: add struct v4l2_query_ext_ctrl and VIDIOC_QUERY_EXT_CTRL.

2014-01-24 Thread Sakari Ailus
Hi Hans, On Mon, Jan 20, 2014 at 01:45:58PM +0100, Hans Verkuil wrote: > + union { > + __u64 val; > + __u32 reserved[4]; > + } step; While I do not question that step is obviously always a positive value (or zero), using a different type from the value (and min and

Re: [RFCv2 PATCH 05/21] videodev2.h: add struct v4l2_query_ext_ctrl and VIDIOC_QUERY_EXT_CTRL.

2014-01-23 Thread Sylwester Nawrocki
On 23/01/14 15:23, Hans Verkuil wrote: > On 01/23/2014 12:02 AM, Sylwester Nawrocki wrote: >> On 01/20/2014 01:45 PM, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> Add a new struct and ioctl to extend the amount of information you can >>> get for a control. >>> >>> It gives back a unit string,

Re: [RFCv2 PATCH 05/21] videodev2.h: add struct v4l2_query_ext_ctrl and VIDIOC_QUERY_EXT_CTRL.

2014-01-23 Thread Hans Verkuil
On 01/23/2014 12:02 AM, Sylwester Nawrocki wrote: > On 01/20/2014 01:45 PM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Add a new struct and ioctl to extend the amount of information you can >> get for a control. >> >> It gives back a unit string, the range is now a s64 type, and the matrix >>

Re: [RFCv2 PATCH 05/21] videodev2.h: add struct v4l2_query_ext_ctrl and VIDIOC_QUERY_EXT_CTRL.

2014-01-22 Thread Sylwester Nawrocki
On 01/20/2014 01:45 PM, Hans Verkuil wrote: From: Hans Verkuil Add a new struct and ioctl to extend the amount of information you can get for a control. It gives back a unit string, the range is now a s64 type, and the matrix and element size can be reported through cols/rows/elem_size. Signed

[RFCv2 PATCH 05/21] videodev2.h: add struct v4l2_query_ext_ctrl and VIDIOC_QUERY_EXT_CTRL.

2014-01-20 Thread Hans Verkuil
From: Hans Verkuil Add a new struct and ioctl to extend the amount of information you can get for a control. It gives back a unit string, the range is now a s64 type, and the matrix and element size can be reported through cols/rows/elem_size. Signed-off-by: Hans Verkuil --- include/uapi/linu