Re: [media] s2255drv: Adjust 13 checks for null pointers

2017-09-21 Thread SF Markus Elfring
>> Would you like to clarify corresponding concerns any more? >> > > Look at the `git log` I did this also for a moment. > and it just copies those lines: The Git software preserves these three message fields (when special characters were used in the commit message). Can you accept such

Re: [media] s2255drv: Adjust 13 checks for null pointers

2017-09-21 Thread Dan Carpenter
On Thu, Sep 21, 2017 at 10:12:56AM +0200, SF Markus Elfring wrote: > >> MIME-Version: 1.0 > >> Content-Type: text/plain; charset=UTF-8 > >> Content-Transfer-Encoding: 8bit > >> > > > > You've been told several times that this stuff doesn't work. > > This functionality might not exactly work in

Re: [media] s2255drv: Adjust 13 checks for null pointers

2017-09-21 Thread SF Markus Elfring
>> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit >> > > You've been told several times that this stuff doesn't work. This functionality might not exactly work in the way that you expect so far. > Try applying this patch with `git am` and you'll

Re: [PATCH 2/5] [media] s2255drv: Adjust 13 checks for null pointers

2017-09-20 Thread Dan Carpenter
On Wed, Sep 20, 2017 at 06:58:56PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 20 Sep 2017 16:46:19 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > You've been told several times that

[PATCH 2/5] [media] s2255drv: Adjust 13 checks for null pointers

2017-09-20 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 20 Sep 2017 16:46:19 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus